Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase on drag and drop (prior pushing) #6

Closed
9 tasks done
anuveyatsu opened this issue Nov 15, 2017 · 2 comments
Closed
9 tasks done

Showcase on drag and drop (prior pushing) #6

anuveyatsu opened this issue Nov 15, 2017 · 2 comments
Assignees

Comments

@anuveyatsu
Copy link
Member

anuveyatsu commented Nov 15, 2017

As a desktop app user I want to see my data's showcase prior publishing online so I can fix any problems and I am in full control of what's going to be live.

Something like "local showcase" which is simplified version of the showcase on the website. On this page, we should report about any issues in data, e.g., validation errors. This page also can have a graph if there are a view + preview tables using original resources. This "local showcase" would use original datapackage.json so some attributes generated by assembler would be skipped:

  • Title - YES
  • Summary table - YES but no size, formats and created/modified dates
  • Short readme - YES
  • Graph - YES
  • Data Files table - NO as we don't have derived versions (but we can have a placeholder if necessary)
  • Preview table - YES
  • Field information table - YES
  • Readme - YES
  • Instructions - NO

Acceptance criteria

  • when I drag and drop a single file it shows me showcase page for this file
  • when I drag and drop a "datapackage.json" file it shows me showcase page generated from it

Tasks

  • set up a templating language
  • copy over showcase page's template from frontend lib
  • copy over bundle.js for rendering graphs and tables
  • refactor index.js to handle "on drop" events on tray
  • create showcase.js module to manage dropped files and generate showcase page
    • if dropped file is datapackage.json, it should generate showcase page from it
    • if dropped file is data file, it should generate datapackage for it and then generate showcase page (similar to cli approach prepareDatasetFromFile funciton)
@anuveyatsu
Copy link
Member Author

FIXED and released here - https://github.com/datahq/data-desktop/releases/tag/v0.2.0

At the moment, preview tables and graphs are not working due to following issues and they will be fixed in the appropriate repos. Once it is fixed, we will update submodule here, after which views should work:

datopian/frontend-showcase-js#171
frictionlessdata/tableschema-js#110

anuveyatsu added a commit that referenced this issue Nov 22, 2017
…nd full readme from correct properties of descriptor - refs #6
anuveyatsu added a commit that referenced this issue Nov 22, 2017
…them are inlined and does not require reading files when in browser - refs #6
@anuveyatsu
Copy link
Member Author

FIXED and fully working from v0.2.2 - https://github.com/datahq/data-desktop/releases/tag/v0.2.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants