-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL/TLS Handshake Latency #113
Comments
@vanbroup what is missing at the moment? Please be specific. |
The SSL/TLS Handshake Latency is measured from the ClientHello message that comes after the TCP ACK until the Finished message which is sent immediately after a change cipher spec message to verify that the key exchange and authentication processes were successful. RFC5246 Section 7.4.9 Finished states:
This allows a client to measure the delay caused by the SSL/TLS Handshake as also implemented by httpstat.py and highlighted in this example: |
@vanbroup how is it different from the current one (TLS Handshake)? |
@juanpaulo thanks, I just tested and it's indeed already there! I was mainly interested in the handshake part and the screenshot in the readme doesn't include the change from pull request #25, also http/httptrace doesn't expose any TLS information (until go 1.8) so I did not even try to run it honestly speaking. Maybe it's smart to update the screenshot in README.md to relect the implementation of the SSL/TLS Handshake Latency. |
Since we moved to the httptrace framework we can only do things that it knows how to do. There is a PR pending the release of go 1.8 that may help.
|
I'm pretty sure it does, that screenshot was taken with 1.0 version of If this is incorrect, it is a bug and should be fixed. On Tue, Oct 25, 2016 at 6:03 PM, Paul van Brouwershaven <
|
@davecheney, I think his point was that the screenshot should be of a TLS request. |
Oh, that's my mistake. When I made the announcement I used the github page for this project. If someone wants to update the screenshot with something more exciting, please send a PR. |
@davecheney I hope #115 is exciting enough. Had to use a different URL since dave.cheney.net doesn't seem to have an SSL endpoint. |
That'll do, I was just using my own site as a demo, anything that offers On Wed, Oct 26, 2016 at 2:15 PM, Juan Paulo Gutierrez <
|
nice, so I think this issue should be marked as resolved right? |
No, we're waiting on Go 1.8 release to get this enhancement. |
Ping. Go was released. |
Can be closed? |
It would be really good to have the SSL/TLS handshake latency.
The text was updated successfully, but these errors were encountered: