code style

[iacore]

(discussion about code style)

[iacore]

I have seen a lot of this kind of code in this project.

    switch (kind) {
        .accent => ret = cs.accent orelse dvui.themeGet().style_content.accent,
        .text => ret = cs.text orelse dvui.themeGet().style_content.text,
        .fill => ret = cs.fill orelse dvui.themeGet().style_content.fill,
        .border => ret = cs.border orelse dvui.themeGet().style_content.border,
        .hover => ret = cs.hover orelse dvui.themeGet().style_content.hover,
        .press => ret = cs.press orelse dvui.themeGet().style_content.press,
        .press_text => ret = cs.press_text orelse dvui.themeGet().style_content.press_text,
    }

It can also be like this. This is shorter, but somehow less readable.

    switch (kind) {
        inline else => |tag| {
            ret = @field(cs, @tagName(tag)) orelse @field(dvui.themeGet().style_content, @tagName(tag));
        },
    }

[david-vanderson]

Yeah - I'm not sure which one I'd rather have. This particular example is interesting because today I was redoing this part. Before today it kind of made sense because both "sides" of the switch were the same. But now the enums are different so the inline else can't be used.

[iacore]

You can still do "prefix-" ++ @tagName(tag).

[david-vanderson]

You are right but that would look like black magic!