From aec358f80f95484aa92e7e0fc86ce46e22bc1323 Mon Sep 17 00:00:00 2001 From: Amy Chen <46451573+amychen1776@users.noreply.github.com> Date: Thu, 19 Dec 2024 13:21:20 -0500 Subject: [PATCH 1/5] add bug report --- .github/ISSUE_TEMPLATE/bug_report.yml | 146 ++++++++++++++------------ 1 file changed, 79 insertions(+), 67 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index d7235eaa..2cfb67e1 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,72 +1,84 @@ name: 🐞 Bug -description: Report a bug or an issue you've found in dbt-athena +description: Report a bug or an issue you've found with dbt-athena title: "[Bug] " -labels: ["bug"] +labels: ["bug", "triage"] body: -- type: markdown - attributes: - value: | - Thanks for taking the time to fill out this bug report! -- type: checkboxes - attributes: - label: Is this a new bug in dbt-athena? - description: > - If this is a request for help or troubleshooting code in your own dbt project, - please join [dbt Community Slack](https://www.getdbt.com/community/join-the-community/) - #db-athena or open a [Discussion question](https://github.com/dbt-athena/dbt-athena/discussions). + - type: markdown + attributes: + value: | + Thanks for taking the time to fill out this bug report! + - type: checkboxes + attributes: + label: Is this a new bug in dbt-athena? + description: > + In other words, is this an error, flaw, failure or fault in our software? - Please search to see if an issue already exists for the bug you encountered. - options: - - label: I believe this is a new bug in dbt-athena - required: true - - label: I have searched the existing issues, and I could not find an existing issue for this bug - required: true -- type: textarea - attributes: - label: Current Behavior - description: A concise description of what you're experiencing. - validations: - required: true -- type: textarea - attributes: - label: Expected Behavior - description: A concise description of what you expected to happen. - validations: - required: true -- type: textarea - attributes: - label: Steps To Reproduce - description: Steps to reproduce the behavior. - placeholder: | - 1. In this environment... - 2. With this config... - 3. Run '...' - 4. See error... - validations: - required: false -- type: textarea - attributes: - label: Environment - description: | - examples: - - **OS**: Ubuntu 20.04 - - **Python**: 3.9.12 (`python3 --version`) - - **dbt-core**: 1.1.1 (`dbt --version`) - - **dbt-athena-community**: 1.1.1 - value: | - - OS: - - Python: - - dbt: - - dbt-athena-community: - render: markdown - validations: - required: false -- type: textarea - attributes: - label: Additional Context - description: | - Links? References? Anything that will give us more context about the issue you are encountering! + If this is a bug that broke existing functionality that used to work, please open a regression issue. + If this is a bug in the dbt-core logic, please open an issue in the dbt-core repository. + If this is a bug experienced while using dbt Cloud, please report to [support](mailto:support@getdbt.com). + If this is a request for help or troubleshooting code in your own dbt project, please join our [dbt Community Slack](https://www.getdbt.com/community/join-the-community/) or open a [Discussion question](https://github.com/dbt-labs/docs.getdbt.com/discussions). - **Tip**: You can attach images or log files by clicking this area to highlight it and then dragging files in. - validations: - required: false + Please search to see if an issue already exists for the bug you encountered. + options: + - label: I believe this is a new bug in dbt-athena + required: true + - label: I have searched the existing issues, and I could not find an existing issue for this bug + required: true + - type: textarea + attributes: + label: Current Behavior + description: A concise description of what you're experiencing. + validations: + required: true + - type: textarea + attributes: + label: Expected Behavior + description: A concise description of what you expected to happen. + validations: + required: true + - type: textarea + attributes: + label: Steps To Reproduce + description: Steps to reproduce the behavior. + placeholder: | + 1. In this environment... + 2. With this config... + 3. Run '...' + 4. See error... + validations: + required: true + - type: textarea + id: logs + attributes: + label: Relevant log output + description: | + If applicable, log output to help explain your problem. + render: shell + validations: + required: false + - type: textarea + attributes: + label: Environment + description: | + examples: + - **OS**: Ubuntu 20.04 + - **Python**: 3.9.12 (`python3 --version`) + - **dbt-core**: 1.1.1 (`dbt --version`) + - **dbt-athena**: 1.1.0 (`dbt --version`) + value: | + - OS: + - Python: + - dbt-core: + - dbt-athena: + render: markdown + validations: + required: false + - type: textarea + attributes: + label: Additional Context + description: | + Links? References? Anything that will give us more context about the issue you are encountering! + + Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in. + validations: + required: false From 61cd294f4a6912532b1cace356417a89a3bcec45 Mon Sep 17 00:00:00 2001 From: Amy Chen <46451573+amychen1776@users.noreply.github.com> Date: Thu, 19 Dec 2024 13:21:57 -0500 Subject: [PATCH 2/5] update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 3ba13e0c..db00b654 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1 +1,14 @@ blank_issues_enabled: false +contact_links: + - name: Ask the community for help + url: https://github.com/dbt-labs/docs.getdbt.com/discussions + about: Need help troubleshooting? Check out our guide on how to ask + - name: Contact dbt Cloud support + url: mailto:support@getdbt.com + about: Are you using dbt Cloud? Contact our support team for help! + - name: Participate in Discussions + url: https://github.com/dbt-labs/dbt-snowflake/discussions + about: Do you have a Big Idea for dbt-snowflake? Read open discussions, or start a new one + - name: Create an issue for dbt-core + url: https://github.com/dbt-labs/dbt-core/issues/new/choose + about: Report a bug or request a feature for dbt-core From 3a3bf83916ef59b19fb5832d64087bd882870cd5 Mon Sep 17 00:00:00 2001 From: Amy Chen <46451573+amychen1776@users.noreply.github.com> Date: Thu, 19 Dec 2024 13:23:30 -0500 Subject: [PATCH 3/5] add feature request and regression report --- ...eature_request.yml => feature-request.yml} | 0 .github/ISSUE_TEMPLATE/regression-report.yml | 82 +++++++++++++++++++ 2 files changed, 82 insertions(+) rename .github/ISSUE_TEMPLATE/{feature_request.yml => feature-request.yml} (100%) create mode 100644 .github/ISSUE_TEMPLATE/regression-report.yml diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature-request.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/feature_request.yml rename to .github/ISSUE_TEMPLATE/feature-request.yml diff --git a/.github/ISSUE_TEMPLATE/regression-report.yml b/.github/ISSUE_TEMPLATE/regression-report.yml new file mode 100644 index 00000000..5c804cba --- /dev/null +++ b/.github/ISSUE_TEMPLATE/regression-report.yml @@ -0,0 +1,82 @@ +name: ☣️ Regression +description: Report a regression you've observed in a newer version of dbt-snowflake +title: "[Regression] <title>" +labels: ["bug", "regression", "triage"] +body: + - type: markdown + attributes: + value: | + Thanks for taking the time to fill out this regression report! + - type: checkboxes + attributes: + label: Is this a regression in a recent version of dbt-snowflake? + description: > + A regression is when documented functionality works as expected in an older version of dbt-snowflake, + and no longer works after upgrading to a newer version of dbt-snowflake + options: + - label: I believe this is a regression in dbt-snowflake functionality + required: true + - label: I have searched the existing issues, and I could not find an existing issue for this regression + required: true + - type: textarea + attributes: + label: Current Behavior + description: A concise description of what you're experiencing. + validations: + required: true + - type: textarea + attributes: + label: Expected/Previous Behavior + description: A concise description of what you expected to happen. + validations: + required: true + - type: textarea + attributes: + label: Steps To Reproduce + description: Steps to reproduce the behavior. + placeholder: | + 1. In this environment... + 2. With this config... + 3. Run '...' + 4. See error... + validations: + required: true + - type: textarea + id: logs + attributes: + label: Relevant log output + description: | + If applicable, log output to help explain your problem. + render: shell + validations: + required: false + - type: textarea + attributes: + label: Environment + description: | + examples: + - **OS**: Ubuntu 20.04 + - **Python**: 3.9.12 (`python3 --version`) + - **dbt-core (working version)**: 1.1.1 (`dbt --version`) + - **dbt-snowflake (working version)**: 1.1.0 (`dbt --version`) + - **dbt-core (regression version)**: 1.2.0 (`dbt --version`) + - **dbt-snowflake (regression version)**: 1.2.0 (`dbt --version`) + value: | + - OS: + - Python: + - dbt-core (working version): + - dbt-snowflake (working version): + - dbt-core (regression version): + - dbt-snowflake (regression version): + render: markdown + validations: + required: true + - type: textarea + attributes: + label: Additional Context + description: | + Links? References? Anything that will give us more context about the issue you are encountering! + + Tip: You can attach images or log files by clicking this area to highlight it and then dragging files in. + validations: + required: false From 12c5831937f212798d8a04f171452d3ab0d29fec Mon Sep 17 00:00:00 2001 From: Amy Chen <46451573+amychen1776@users.noreply.github.com> Date: Thu, 19 Dec 2024 13:24:00 -0500 Subject: [PATCH 4/5] remove other file --- .github/ISSUE_TEMPLATE/other.yml | 30 ------------------------------ 1 file changed, 30 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/other.yml diff --git a/.github/ISSUE_TEMPLATE/other.yml b/.github/ISSUE_TEMPLATE/other.yml deleted file mode 100644 index ea166843..00000000 --- a/.github/ISSUE_TEMPLATE/other.yml +++ /dev/null @@ -1,30 +0,0 @@ -name: Other -description: Anything that is not a bug or a feature -title: "<title>" -labels: [] -body: -- type: checkboxes - attributes: - label: Is this your first time submitting an issue in dbt-athena? - description: > - We want to make sure that features are distinct and discoverable, - so that other members of the community can find them and offer their thoughts. - - Issues are the right place to request straightforward extensions of existing dbt functionality. - For "big ideas" about future capabilities of dbt, we ask that you open a - options: - - label: I have searched the existing issues, and I could not find an existing issue for this feature - required: true -- type: textarea - attributes: - label: Describe your request/question - description: A clear and concise description of what you want to happen. - validations: - required: true -- type: textarea - attributes: - label: Anything else? - description: | - Links? References? Anything that will give us more context about the requests or question - validations: - required: false From 5a379c0b19fa8ffa358d7cd9fcbc4adde27e6b74 Mon Sep 17 00:00:00 2001 From: Amy Chen <46451573+amychen1776@users.noreply.github.com> Date: Thu, 19 Dec 2024 13:26:04 -0500 Subject: [PATCH 5/5] remove dbt-snowflake mention --- .github/ISSUE_TEMPLATE/regression-report.yml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/regression-report.yml b/.github/ISSUE_TEMPLATE/regression-report.yml index 5c804cba..5c10d2b8 100644 --- a/.github/ISSUE_TEMPLATE/regression-report.yml +++ b/.github/ISSUE_TEMPLATE/regression-report.yml @@ -1,5 +1,5 @@ name: ☣️ Regression -description: Report a regression you've observed in a newer version of dbt-snowflake +description: Report a regression you've observed in a newer version of dbt-athena title: "[Regression] <title>" labels: ["bug", "regression", "triage"] body: @@ -9,12 +9,12 @@ body: Thanks for taking the time to fill out this regression report! - type: checkboxes attributes: - label: Is this a regression in a recent version of dbt-snowflake? + label: Is this a regression in a recent version of dbt-athena? description: > - A regression is when documented functionality works as expected in an older version of dbt-snowflake, - and no longer works after upgrading to a newer version of dbt-snowflake + A regression is when documented functionality works as expected in an older version of dbt-athena, + and no longer works after upgrading to a newer version of dbt-athena options: - - label: I believe this is a regression in dbt-snowflake functionality + - label: I believe this is a regression in dbt-athena functionality required: true - label: I have searched the existing issues, and I could not find an existing issue for this regression required: true @@ -58,16 +58,16 @@ body: - **OS**: Ubuntu 20.04 - **Python**: 3.9.12 (`python3 --version`) - **dbt-core (working version)**: 1.1.1 (`dbt --version`) - - **dbt-snowflake (working version)**: 1.1.0 (`dbt --version`) + - **dbt-athena (working version)**: 1.1.0 (`dbt --version`) - **dbt-core (regression version)**: 1.2.0 (`dbt --version`) - - **dbt-snowflake (regression version)**: 1.2.0 (`dbt --version`) + - **dbt-athena (regression version)**: 1.2.0 (`dbt --version`) value: | - OS: - Python: - dbt-core (working version): - - dbt-snowflake (working version): + - dbt-athena (working version): - dbt-core (regression version): - - dbt-snowflake (regression version): + - dbt-athena (regression version): render: markdown validations: required: true