Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-478] Remove Databricks specific tests #502

Open
3 tasks
Tracked by #718
emmyoop opened this issue Apr 21, 2023 · 0 comments
Open
3 tasks
Tracked by #718

[ADAP-478] Remove Databricks specific tests #502

emmyoop opened this issue Apr 21, 2023 · 0 comments
Labels
pkg:dbt-spark Issue affects dbt-spark type:task Eng-driven work

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 21, 2023 •
edited
Loading

High Level Task

Remove the Databricks profiles from dbt-spark integration tests.

Acceptance Criteria

  • Profiles for databricks_sql_endpoint, databricks_sql_endpoint and databricks_http_cluster are removed from codebase
  • All decorators are updated to reflect the removal of above profiles
  • All tests that should be removed are fully removed

Details

This is a bit complex since tests are tagged to be skipped, not to be run. The tests that need to be fully removed are the ones that have the following decorator:

@pytest.mark.skip_profile("spark_session", "apache_spark")

If the decorator contains databricks_sql_endpoint, databricks_sql_endpoint or databricks_http_cluster the decorator just need to be modified.

conftest.py also needs to be modified to remove the databricks profiles.

Additional Notes

Since we will be removing the Databricks profiles in the GitHub Action, this will be dead code but the tests will continue to work.
@emmyoop emmyoop mentioned this issue Apr 21, 2023
Closed
@github-actions github-actions bot changed the title Remove databricks specific tests [ADAP-478] Remove databricks specific tests Apr 21, 2023
@emmyoop emmyoop changed the title [ADAP-478] Remove databricks specific tests [ADAP-478] Remove Databricks specific tests Apr 21, 2023
@mikealfare mikealfare added the type:task Eng-driven work label Aug 3, 2023
@mikealfare mikealfare added the pkg:dbt-spark Issue affects dbt-spark label Jan 13, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-spark Jan 13, 2025
mikealfare added a commit that referenced this issue Jan 24, 2025
@dependabot @mikealfare @VersusFacit
Bump mypy from 1.0.1 to 1.1.1 (#502)
41cf043 
* Bump mypy from 1.0.1 to 1.1.1

Bumps [mypy](https://github.com/python/mypy) from 1.0.1 to 1.1.1.
- [Release notes](https://github.com/python/mypy/releases)
- [Commits](python/mypy@v1.0.1...v1.1.1)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* aligned versions in `.pre-commit-config.yaml` with `dev-requiremnts.txt`

* update flake8 version condition to inflect at 3.8.1 instead of 3.8

* cleaned up `Makefile`

* cleaned up `Makefile`

* Revert "cleaned up `Makefile`"

This reverts commit 52783d2a2a0af3b86cb70a585f13111d1c38a395.

* Revert "Revert "cleaned up `Makefile`""

This reverts commit 3f9ef414415a6ee2f788c53959cda3e8e778bfa7.

* Revert "Revert "Revert "cleaned up `Makefile`"""

This reverts commit eb8ffb6103269cfa8e6fd9085a6c0ab6caff4410.

* Revert "cleaned up `Makefile`"

This reverts commit 2eadd98e77febed74ffb33bcb8745410b2e46f94.

* Revert "update flake8 version condition to inflect at 3.8.1 instead of 3.8"

This reverts commit 819bcdfded810c9797b88de492fbfc77dfed0576.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mike Alfare <[email protected]>
Co-authored-by: Mila Page <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg:dbt-spark Issue affects dbt-spark type:task Eng-driven work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emmyoop @mikealfare