Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-480] Make the local docker container work reliably #500

Open
3 tasks
Tracked by #718
emmyoop opened this issue Apr 21, 2023 · 0 comments
Open
3 tasks
Tracked by #718

[ADAP-480] Make the local docker container work reliably #500

emmyoop opened this issue Apr 21, 2023 · 0 comments
Assignees
@VersusFacit
Labels
pkg:dbt-spark Issue affects dbt-spark type:task Eng-driven work

Comments

@emmyoop
Copy link
Member

emmyoop commented Apr 21, 2023 •
edited
Loading

High Level Task

There is currently a docker-compose file in dbt-spark. It's finicky and doesn't always work. If it did work, local development would be a lot easier.

Acceptance Criteria

  • A Docker container we can reliably spin up to test locally before pushing changes up
  • A make command to set everything up (See make setup-db in dbt-core)
  • Documentation in the repo on how to run the container for local development

Details

dbt-core uses a local docker container to run postgres. This could possibly work similarly. Update the Makefile appropriately to reflect it if the docker container can be fixed.

Some report that if you just restart the container a few times it will start working. But all the integration tests don't run, it fails out early.

Unknowns

Why doesn't it work?

Additional Notes

Relates to: dbt-labs/dbt-spark#386
@emmyoop emmyoop mentioned this issue Apr 21, 2023
Closed
@github-actions github-actions bot changed the title Make the local docker container work reliably [ADAP-480] Make the local docker container work reliably Apr 21, 2023
@VersusFacit VersusFacit self-assigned this Apr 26, 2023
@mikealfare mikealfare added the type:task Eng-driven work label Aug 3, 2023
@mikealfare mikealfare added the pkg:dbt-spark Issue affects dbt-spark label Jan 13, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-spark Jan 13, 2025
mikealfare pushed a commit that referenced this issue Jan 20, 2025
@colin-rogers-dbt
add dependent_projects_dict to utils.py (#500)
97e265a 
* fix utils.py
mikealfare pushed a commit that referenced this issue Jan 24, 2025
@emmyoop
support contracts on models materialized as view (#500)
9d2f8f3 
* first pass with contract check

* rename test class

* file merge cleanup

* clean up tests

* changelog

* fix class name

* remove dbt-core pin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VersusFacit VersusFacit

Labels
pkg:dbt-spark Issue affects dbt-spark type:task Eng-driven work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emmyoop @mikealfare @VersusFacit