diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index b887575a..ef653bb0 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -6,6 +6,7 @@ * Improved Kubernetes definition validation * Allow RKE2 deployments with Calico, Cilium and Multus on aarch64 platforms +* Helm chart installation backOffLimit changed from 1000(default) to 20 ## API diff --git a/pkg/combustion/kubernetes_test.go b/pkg/combustion/kubernetes_test.go index 71d1c922..09ace3aa 100644 --- a/pkg/combustion/kubernetes_test.go +++ b/pkg/combustion/kubernetes_test.go @@ -719,6 +719,7 @@ spec: chartContent: some-content targetNamespace: web createNamespace: true + backOffLimit: 20 ` b, err = os.ReadFile(chartPath) require.NoError(t, err) diff --git a/pkg/registry/helm_crd.go b/pkg/registry/helm_crd.go index 2ac8b146..2f974953 100644 --- a/pkg/registry/helm_crd.go +++ b/pkg/registry/helm_crd.go @@ -10,6 +10,7 @@ const ( helmChartAPIVersion = "helm.cattle.io/v1" helmChartKind = "HelmChart" helmChartSource = "edge-image-builder" + helmBackoffLimit = 20 ) type HelmCRD struct { @@ -26,6 +27,7 @@ type HelmCRD struct { ChartContent string `yaml:"chartContent"` TargetNamespace string `yaml:"targetNamespace,omitempty"` CreateNamespace bool `yaml:"createNamespace,omitempty"` + BackOffLimit int `yaml:"backOffLimit"` } `yaml:"spec"` } @@ -53,12 +55,14 @@ func NewHelmCRD(chart *image.HelmChart, chartContent, valuesContent, repositoryU ChartContent string `yaml:"chartContent"` TargetNamespace string `yaml:"targetNamespace,omitempty"` CreateNamespace bool `yaml:"createNamespace,omitempty"` + BackOffLimit int `yaml:"backOffLimit"` }{ Version: chart.Version, ValuesContent: valuesContent, ChartContent: chartContent, TargetNamespace: chart.TargetNamespace, CreateNamespace: chart.CreateNamespace, + BackOffLimit: helmBackoffLimit, }, } }