Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polyfill missing stuff for IE #1507

Closed
gordonwoodhull opened this issue Dec 7, 2018 · 5 comments
Closed

polyfill missing stuff for IE #1507

gordonwoodhull opened this issue Dec 7, 2018 · 5 comments
Labels

Comments

@gordonwoodhull
Copy link
Contributor

dc.js 3.* still supports IE, sad as it is.

D3v5 introduced a couple of ES6 library dependencies, Fetch and Promise. We should include polyfills on all our pages so that they still work in IE.

@gordonwoodhull
Copy link
Contributor Author

They are easy to polyfill; just grab whatwg-fetch and promise-polyfill from NPM, and include the libraries in your page before the use of d3.fetch.

I tried this on the main page and IE works again. I'm now looking into how to conveniently add it to all the pages (or at least those that use Fetch). I guess none of our tests use d3.csv or d3.json or we would have noticed this earlier.

Thanks @sgavathe for the report!

@sgavathe
Copy link

sgavathe commented Dec 7, 2018

@gordonwoodhull Thanks for giving a solution to it! The polyfill fixes for IE does makes sense.

gordonwoodhull added a commit that referenced this issue Dec 7, 2018
@gordonwoodhull
Copy link
Contributor Author

Fixed all examples in dc.js; will now proceed to dc-js/dc.datatables.js#7

@gordonwoodhull
Copy link
Contributor Author

There are a few remaining arrow functions and Object.assign - following up with a few more commits here.

gordonwoodhull added a commit that referenced this issue Dec 7, 2018
this function is quite useful and it's used by sunburst
I think it's worth the bloat here

for #1507
gordonwoodhull added a commit that referenced this issue Dec 7, 2018
@gordonwoodhull
Copy link
Contributor Author

boxplot and sunburst examples now work - the Object.assign polyfill is built-in and the Array.find polyfill is pasted into the relevant examples. All examples are tested to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants