From 7879f0a965bcc86308507354d5806169af791ae5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Attila=20Ber=C3=A9nyi?= Date: Mon, 15 Mar 2021 16:47:55 +0100 Subject: [PATCH] Fixes https://github.com/dc-js/dc.js/issues/1818 --- src/base/coordinate-grid-mixin.js | 4 ++-- web-src/examples/scatter-top.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/base/coordinate-grid-mixin.js b/src/base/coordinate-grid-mixin.js index 7a77c1db5..352d31567 100644 --- a/src/base/coordinate-grid-mixin.js +++ b/src/base/coordinate-grid-mixin.js @@ -579,7 +579,7 @@ export class CoordinateGridMixin extends ColorMixin(MarginMixin) { .attr('x1', d => this._x(d)) .attr('y1', this._xAxisY() - this.margins().top) .attr('x2', d => this._x(d)) - .attr('y2', 0) + .attr('y2', this._useTopXAxis ? this.height() - this.margins().top - this.margins().bottom : 0) .attr('opacity', 0); transition(linesGEnter, this.transitionDuration(), this.transitionDelay()) .attr('opacity', 0.5); @@ -589,7 +589,7 @@ export class CoordinateGridMixin extends ColorMixin(MarginMixin) { .attr('x1', d => this._x(d)) .attr('y1', this._xAxisY() - this.margins().top) .attr('x2', d => this._x(d)) - .attr('y2', 0); + .attr('y2', this._useTopXAxis ? this.height() - this.margins().top - this.margins().bottom : 0); // exit lines.exit().remove(); diff --git a/web-src/examples/scatter-top.html b/web-src/examples/scatter-top.html index d2775b72c..16e7cbfaf 100644 --- a/web-src/examples/scatter-top.html +++ b/web-src/examples/scatter-top.html @@ -34,6 +34,7 @@ .margins({top: 30, right: 0, bottom: 10, left: 30}) .x(d3.scaleLinear().domain([6,20])) .useTopXAxis(true) + .renderVerticalGridLines(true) .xAxisLabel("This is the X Axis!") .brushOn(false) .symbolSize(8)