completion fails with ValueError

[benatouba]

Hi,
thx for your work on the server. I really appreciate it.

I am using the server with neovim. Unfortunately the completion does not properly work. Most of the time the log has the following errors:

ValueError: too many values to unpack (expected 2)

salt-server.log

[dcermak]

Could you also upload the file that you were editing?

[benatouba]

I made a simple top.sls file and post the log here. There are multiple errors in the log. I am not sure which one messes up the completions and which are acceptable.
salt-server.log

base:
  '*':
    - pkg.installed:

The salt version is 3003.2

[agraul]

Hi @benatouba,

is the code block the whole top.sls file you have? As far as I know you need two files, the top.sls which contains a mapping of minions to SLS files and (at least) one SLS file itself.

For example:

# /srv/salt/top.sls
base:
  '*':                     # matches all minions
    - test                 # matches test.sls, assigned to all matched minions

# /srv/salt/test.sls
vim:
  pkg.installed

Do you get the same error with a SLS file setup like I described?

[agraul]

I think both the ValueError: too many values to unpack (expected 2) and many of the yaml.scanner.ScannerError are fixed with #20

[dcermak]

@benatouba Could you recheck with the latest state from main?

[benatouba]

As it looks to me right now, the updates solved this issue. I still get no completion but that might have a different source.

The log does only show "yaml.scan.errrors" with jinja templates (%). But that is not yet implemented, right?

[dcermak]

Benjamin Schmidt ***@***.***> writes:

As it looks to me right now, the updates solved this issue. I still get no completion but that might have a different source. The log does only show "yaml.scan.errrors" with jinja templates (%). But that is not yet implemented, right?

You are (unfortunately) correct, we did not get around to implement yaml templates yet.

[benatouba]

Thx for the work so far. There still seem to be some problems with getting completion but I need to find out whether they might just be on my end.

[benatouba]

Now I get completion for submodules, some time after I open the file. It seems to take some time. Here is the log file for the test.sls suggested by @agraul . As you can see there are no errors in the log. Maybe there is still helpful stuff for you in there.
salt-server.log