Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

receive callback for .noteOn message not called when two keys are pressed at the same time #13

Open
rafagan opened this issue Dec 13, 2021 · 6 comments

Comments

@rafagan
Copy link

rafagan commented Dec 13, 2021

When I press two keyboard keys at the same time, the receive(_ packet: MIDIPacket, from source: MIDISource) is called once for .noteOn, and the same behavior not happen with .noteOff for packet.message.

Any help?

@rafagan
Copy link
Author

rafagan commented Dec 14, 2021

I think there's something related with MIDIInputPortCreate. This code works well and it uses MIDIInputPortCreateWithProtocol with MIDIProtocolID._1_0.

@rafagan
Copy link
Author

rafagan commented Dec 16, 2021

The function MIDIInputPortCreate is deprecated:

https://developer.apple.com/documentation/coremidi/1495225-midiinputportcreate

@dclelland
Copy link
Owner

Hi, haven't used this project in a really long time, but I will take a look at this today

@dclelland
Copy link
Owner

Ah, I get it. The way my MIDIPacket parser thing works, it is only capable of parsing one message.

https://github.com/dclelland/Gong/blob/master/Sources/Gong/Core/MIDIPacket.swift#L246

Looking at moving everything over to the new methods (MIDIEventPacket et. al.)

Working on this on a branch.

master...update

@vrschgn
Copy link

vrschgn commented Oct 22, 2022

@dclelland Hi! I got the same issue. Is this already fixed in update branch?

@dclelland
Copy link
Owner

@dclelland Hi! I got the same issue. Is this already fixed in update branch?

Eh, I'm pretty busy these days, I'd say it's unlikely I am going to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants