WP_DEBUG issues

[tobylewis]

Hi David,

Excellent plugin, I don't understand why bbPress does not do this out of the box.

I always have WP_DEBUG = TRUE, cause I'm debugging my code, so have come across a few small problems. Basically these all cause notice/warning output which then causes "Cannot modify header information" which means the redirect after a post/page save does not work.

First bbppt_debug() outputs info both on save and on the ajax call which I don't want but I also don't want to turn off WP_DEBUG_DISPLAY universally so would be good if there was a separate constant (like "BBPPT_DEBUG_DISPLAY") to turn this on/off.

Second, in process_topic_option( ), $bbppt_options['copy_tags'] and $bbppt_options['copy_comments'] will be unknown indices if not checked (or not even in the form) on the save $_POST case and so these generate warnings. If wrapped in !empty( ) there are no warnings as you have done in other places.

Finally if the post/page is set not to use the forums for comments then the $topic_id var is never initialised and generates an unknown variable error when calling the action at the end of the method

do_action( 'bbppt_topic_associated', $post_ID, $topic_ID );

I've made these mods in my copy of the plugin. It looks like this hasn't had a new release for a while so I'm not asking for help or an urgent update. Just passing this on in the hope you can include the changes next time you edit the project.

Cheers
Toby