Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalisation: grouping ticket #320

Closed
2 of 3 tasks
PascalinDe opened this issue Aug 30, 2023 · 3 comments
Closed
2 of 3 tasks

Internalisation: grouping ticket #320

PascalinDe opened this issue Aug 30, 2023 · 3 comments

Comments

@PascalinDe
Copy link
Contributor

PascalinDe commented Aug 30, 2023

This ticket is to group smaller tickets related to internalisation:

@PascalinDe
Copy link
Contributor Author

in my opinion, the first thing to address is that the backend (and sometimes the frontend as well) handles form titles in the form of an object

{en: 'english title', de: 'german title', fr: 'french title'}

that gets than transformed into flat strings Title, TitleDe and TitleFr (same with other objects), the code on the frontend's side should be adapted so that it continues to handle the object is it is send from the backend, since that easily allows for adding/removing languages

@ineiti
Copy link
Member

ineiti commented Aug 31, 2023

Even better, use a Map. So you don't need to have Objects.entries(titles) if you want to use an iterator.

@PascalinDe PascalinDe changed the title overhaul internalisation clean up internalisation Sep 1, 2023
@PascalinDe PascalinDe changed the title clean up internalisation internalisation: overhaul Sep 1, 2023
@PascalinDe PascalinDe changed the title internalisation: overhaul internalisation: grouping ticket Sep 1, 2023
@PascalinDe PascalinDe changed the title internalisation: grouping ticket Internalisation: grouping ticket Sep 1, 2023
@PascalinDe PascalinDe moved this to Todo in D-Voting Sep 27, 2023
@PascalinDe
Copy link
Contributor Author

grouping tickets are not working well for this project, I'll close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants