From 20fbfbd95c17cf4e4c0b7f273b916c4c88acc3c3 Mon Sep 17 00:00:00 2001 From: Linus Gasser Date: Fri, 5 Jul 2024 09:45:36 +0200 Subject: [PATCH 1/2] Only do sonarcloud on dedis/dela --- .github/workflows/go_test.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/go_test.yml b/.github/workflows/go_test.yml index 8918c53b..4ed35d3d 100644 --- a/.github/workflows/go_test.yml +++ b/.github/workflows/go_test.yml @@ -18,6 +18,7 @@ jobs: runs-on: ${{matrix.platform}} env: LLVL: trace + coverage: ${{ matrix.platform == 'ubuntu-latest' && github.repository == 'dedis/dela' }} steps: - name: Check out code into the Go module directory uses: actions/checkout@v4 @@ -30,17 +31,17 @@ jobs: - name: Test without coverage env: CRY_LVL: "warn" - if: matrix.platform == 'macos-latest' || matrix.platform == 'windows-latest' + if: ${{ env.coverage == 'false' }} run: make test - name: Test with coverage env: CRY_LVL: "warn" - if: matrix.platform == 'ubuntu-latest' + if: ${{ env.coverage == 'true' }} run: make coverage - name: Sonarcloud scan - if: matrix.platform == 'ubuntu-latest' + if: ${{ env.coverage == 'true' }} uses: sonarsource/sonarcloud-github-action@master with: args: > @@ -53,7 +54,7 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - name: Send coverage - if: matrix.platform == 'ubuntu-latest' + if: ${{ env.coverage == 'true' }} uses: shogo82148/actions-goveralls@v1 with: path-to-profile: profile.cov From 4d51a74503b6261832f37da67e9c2d7856032da1 Mon Sep 17 00:00:00 2001 From: Linus Gasser Date: Tue, 2 Jul 2024 16:28:45 +0200 Subject: [PATCH 2/2] Code cleanup Co-authored-by: Zach Xion XioZ@users.noreply.github.com --- mino/mino.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mino/mino.go b/mino/mino.go index a935fa07..537bf01d 100644 --- a/mino/mino.go +++ b/mino/mino.go @@ -150,8 +150,8 @@ type Sender interface { // Receiver is an abstraction to receive messages from a stream in the context // of a distributed RPC. type Receiver interface { - // Recv waits for a message to send received from the stream. It returns the - // address of the original sender and the message, or a message if the + // Recv waits for a message to be received from the stream. It returns the + // address of the original sender and the message, or an error if the // stream is closed or the context is done. Recv(context.Context) (Address, serde.Message, error) }