Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods after OSCALModel implementation #887

Open
2 tasks
meganwolf0 opened this issue Jan 17, 2025 · 0 comments
Open
2 tasks

Remove deprecated methods after OSCALModel implementation #887

meganwolf0 opened this issue Jan 17, 2025 · 0 comments
Labels
triage Awaiting triage from the team

Comments

@meganwolf0
Copy link
Collaborator

Describe what should be investigated or refactored

Remove old methods that are no longer valid with updated OSCALModel interface implementation, for instance:

  • WriteOscalModel
  • MergeOscalModels
  • (others?)

This issue can also contain the swap of the GetType method in the OSCALModel interface to instead of returning the string value for an oscal model, to assign const iota and return, as this is believed to be a cleaner, more idiomatic approach

Additional context

Blocked by #747, #748, #873

Expected Deliverable

  • Old code and tests removed
  • Updated OSCALModel interface definition
@github-actions github-actions bot added the triage Awaiting triage from the team label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Awaiting triage from the team
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant