Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Component Definitions on UUID #893

Closed
1 task
meganwolf0 opened this issue Jan 21, 2025 · 0 comments · Fixed by #894
Closed
1 task

Merge Component Definitions on UUID #893

meganwolf0 opened this issue Jan 21, 2025 · 0 comments · Fixed by #894
Assignees
Labels
enhancement New feature or request

Comments

@meganwolf0
Copy link
Collaborator

meganwolf0 commented Jan 21, 2025

Describe what should be investigated or refactored

Currently the MergeComponentDefinitions merges components based on unique titles, it would probably be better/more compliant with OSCAL for this function to be merging them on unique component UUIDs instead.

This function also need to be re-worked such that it can merge two component definitions where one does not have any components (which is valid oscal)

Links to any relevant code

func MergeComponentDefinitions(original *oscalTypes.ComponentDefinition, latest *oscalTypes.ComponentDefinition) (*oscalTypes.ComponentDefinition, error) {

Additional context

None

Expected Deliverable

  • Updated function to use component.UUID as map keys + Updated tests (will need to re-write these)
@github-actions github-actions bot added the triage Awaiting triage from the team label Jan 21, 2025
@meganwolf0 meganwolf0 self-assigned this Jan 21, 2025
@meganwolf0 meganwolf0 added enhancement New feature or request and removed triage Awaiting triage from the team labels Jan 22, 2025
@meganwolf0 meganwolf0 moved this from 🆕 New to 👀 In Review in Lula and Friends Jan 22, 2025
@meganwolf0 meganwolf0 moved this from 👀 In Review to 🏗 In Progress in Lula and Friends Jan 23, 2025
@meganwolf0 meganwolf0 moved this from 🏗 In Progress to 👀 In Review in Lula and Friends Jan 23, 2025
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Lula and Friends Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant