Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy Mode #8

Open
defuse opened this issue Mar 1, 2016 · 1 comment
Open

Lazy Mode #8

defuse opened this issue Mar 1, 2016 · 1 comment

Comments

@defuse
Copy link
Owner

defuse commented Mar 1, 2016

Possible Feature: Return as soon as the first partial or non-partial match is found. This would make the complexity of running a query more predictable, and prevent DoS on crackstation.net when tons of matches are returned (e.g. in the case of LM with a common prefix).

Unfortunately, it's not a good idea to support the better version of this feature, which is "return a full match if it is found, otherwise return the first partial match" because to find the full match you have to scan through all of the partial matches anyway, so we might as well return them (and let the caller decide to disregard them).

@defuse
Copy link
Owner Author

defuse commented Mar 1, 2016

Well, that second more-desirable feature could be supported if I indexed on a hash of the entire hash, but that's too much work for right now, and probably isn't worth doing anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant