Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow interactive command sessions in deis run #98

Closed
jeroenvisser101 opened this issue Jun 24, 2016 · 6 comments
Closed

Allow interactive command sessions in deis run #98

jeroenvisser101 opened this issue Jun 24, 2016 · 6 comments

Comments

@jeroenvisser101
Copy link

(from deis/deis#117 (comment))

This seems to be a longstanding issue but something that would be super nice for Workflow.

Is this planned yet for v2? I couldn't find any issues referencing it.

@bacongobbler
Copy link
Member

Hey @jeroenvisser101, this is not yet slated as something for v2, however now that we are using k8s this should be relatively easier to implement compared to v1.

@jeroenvisser101
Copy link
Author

@bacongobbler would proxying this locally to kubectl be an option? That would make this very simple to implement, I think. (it would create a new runner pod, get the pod name, and then exec -ti in that pod, delete when done?)

@bacongobbler
Copy link
Member

bacongobbler commented Jun 24, 2016

I don't think we can assume that the kubernetes api server is publicly accessible, which strikes out the idea of proxying to kubectl.

@bacongobbler
Copy link
Member

bacongobbler commented Jun 24, 2016

The run implementation currently works like that (create a runner pod, get the pod name, wait for it to finish, retrieve the logs, delete when done), however the limitations are still the same as deis/deis#117. The limitation being that WSGI cannot handle long-running request/responses such as a websocket. We need to effectively create a new component to handle the proxying between the pod and the client outside of the controller w/auth... same for deis logs -f for deis/deis#465.

@rimusz
Copy link

rimusz commented Oct 11, 2016

any update on this?

@Cryptophobia
Copy link

This issue was moved to teamhephy/workflow-cli#28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants