Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "https" dependencies in package.json #27542

Open
jiridanek opened this issue Jan 3, 2025 · 1 comment
Open

Support "https" dependencies in package.json #27542

jiridanek opened this issue Jan 3, 2025 · 1 comment
Labels
node compat suggestion suggestions for new features (yet to be agreed)

Comments

@jiridanek
Copy link

$ deno --version
deno 2.1.4 (stable, release, aarch64-apple-darwin)
v8 13.0.245.12-rusty
typescript 5.6.2

My package.json contains

{
  // ...
  "devDependencies": {
    // ...
    "odh-dashboard-frontend": "https://github.com/opendatahub-io/odh-dashboard.git#semver:v2.29.0&path:/frontend",

This package installs fine with pnpm, but with deno install, it is not installed, and I get a Warning about it.

$ deno install
Warning Not implemented scheme 'https'
    at file:///Users/jdanek/IdeaProjects/notebooks/tests/deno/package.json

Possibly related issue

@jiridanek
Copy link
Author

jiridanek commented Jan 3, 2025

What schemes are actually implemented?

Looking at https://github.com/denoland/deno/blob/v2.1.4/tests/specs/install/invalid_scheme/install.out, git: cannot be used either.

edit: looks like all these are not implemented https://github.com/denoland/deno_package_json/blob/0.4.0/src/lib.rs#L618-L620

@dsherret dsherret changed the title deno install: Warning Not implemented scheme 'https' Support "https" dependencies in package.json Jan 3, 2025
@dsherret dsherret added suggestion suggestions for new features (yet to be agreed) node compat labels Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node compat suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

2 participants