You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adding a new // deno-lint-ignore comment line before an offending line of code, is useful to draw attention. But when the ignore issue is minor, ideally attention should not be drawn, by simply adding the comment after the statement, without creating a new line for it.
Before
import{getFirestore,// deno-lint-ignore no-unused-vars -- Firestore is used as a return type but https://github.com/denoland/deno/issues/27583#issue-2774370928Firestore,}from'firebase-admin/firestore';
After
import{getFirestore,Firestore}from'firebase-admin/firestore';// deno-lint-ignore-line no-unused-vars -- Firestore is used as a return type but https://github.com/denoland/deno/issues/27583#issue-2774370928
Prior art
ESLint offers// eslint-disable-line in addition to // eslint-disable-next-line.
The text was updated successfully, but these errors were encountered:
I personally don't think this should be done because it adds more complexity to deno lint and it makes linting slower by having to check for more places for ignore comments (though, probably doesn't really matter).
Reason
Adding a new
// deno-lint-ignore
comment line before an offending line of code, is useful to draw attention. But when the ignore issue is minor, ideally attention should not be drawn, by simply adding the comment after the statement, without creating a new line for it.Before
After
Prior art
ESLint offers
// eslint-disable-line
in addition to// eslint-disable-next-line
.The text was updated successfully, but these errors were encountered: