[CST] Resolve Silent Failure bugs and requirement changes

[pmclaren19]

Background Context

Bug

• Found that evss document uploads need to have a delete_date field added to them so that we can delete successful records after 60 days

• Found that we need to add the document_type mapped to the actual name of the document instead of just displaying the document type aka L014 , instead we want to show 'Birth Certificate'

• Found that the Type 2 errors for upload docs are not populating the failed_date in the template_metadata so the failure email job is not working for those. Need to update the polling job so that we set this field.

• Need to set acknowledgment_date for evss and lighthouse type 1 and 2 errors

• Need to set error_message for evss and lighthouse type 1 and 2 errors

• We need to have tests in failure_notification_email_job_spec.rb that are testing type 1 and 2 errors

• Need to set failed_date for evss and lighthouse type 1 and 2 errors

• Need to set template_metadata -> personalisation -> date_failed for evss and lighthouse type 1 and 2 errors

Outcome, Success Measure, KPI(S), and Tracking Link

• Add here

Design

• Add here

Enablement team (if needed)

@member of team

Engineering

• Add here

Out of scope

• Add here

Open questions

• Add here

Tasks

• Add delete_date to app/sidekiq/evss/document_upload.rb under the update_evidence_submission_status method
• Update the code in app/services/evss_claim_service.rb under the create_personalisation method to set the document_type mapped label name instead of the name
• Update the code in lib/lighthouse/benefits_documents/service.rb under the create_personalisation method to set the document_type mapped label name instead of the name
• Update the polling job so that we set the template_metadata failed_date.
• Need to set acknowledgment_date for evss and lighthouse type 1 and 2 errors
• Need to set error_message for evss and lighthouse type 1 and 2 errors
• We need to have tests in failure_notification_email_job_spec.rb that are testing type 1 and 2 errors
• Need to set failed_date for evss and lighthouse type 1 and 2 errors
• Need to set template_metadata -> personalisation -> date_failed for evss and lighthouse type 1 and 2 errors

Definition of Done

• Meets acceptance criteria
• Passed E2E testing (90% coverage)
• Passed unit testing (90% coverage)
• Passed integration testing (if applicable)
• Code reviewed (internal)
• Submitted to staging
• Team approved production verification process
• Design performs design QA and verifies the implementation matches the design spec
• Accessibility specialist performs accessibility review (in code or design)
• Engineering identifies staging users required to test and shares account and credentials with design and product
• Product performs functional QA and verifies acceptance criteria was met

Acceptance Criteria

• Evss records are deleted and have a delete date
• Evss records have the document_type set to the label
• Lighthouse records have the document_type set to the label
• records that have a type 2 error have the template_metadata failed_date set

[pmclaren19]

Tested the delete_date changes in staging and things look good.

Also tested the document_type changes for EVSS and Lighthouse and they look good

[pmclaren19]

Found another bug where type 2 errors are not being sent with the failure email job. Updating this ticket so that we can make a pr to resolve.