From 47b941fafd6bad8e734a1827717af2ccdf8ec8e6 Mon Sep 17 00:00:00 2001 From: Carlos Palhares Date: Thu, 8 Feb 2024 14:09:48 -0300 Subject: [PATCH] Update rubocop to latest version - regenerate todo --- .rubocop.yml | 13 ++- .rubocop_todo.yml | 209 +++++++++++++++++++++++++++++++++++++--------- Gemfile | 3 +- 3 files changed, 175 insertions(+), 50 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index d5e192c0..dc912a27 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -2,6 +2,9 @@ inherit_from: - .rubocop_todo.yml +require: + - rubocop-performance + AllCops: TargetRubyVersion: 2.4 @@ -20,7 +23,7 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 250 -Metrics/LineLength: +Layout/LineLength: Max: 120 Exclude: - 'departure.gemspec' @@ -38,12 +41,6 @@ Metrics/ParameterLists: Performance/Casecmp: Enabled: false -Style/BracesAroundHashParameters: - Exclude: - - 'spec/fixtures/migrate/**.rb' - - 'spec/integration/**.rb' - - 'spec/lhm/adapter/**.rb' - Style/CommandLiteral: Exclude: - 'test_database.rb' @@ -64,6 +61,6 @@ Layout/MultilineMethodCallIndentation: Style/SymbolArray: Enabled: false -Style/UnneededPercentQ: +Style/RedundantPercentQ: Exclude: - 'departure.gemspec' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 9d036d0b..c8502695 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,84 +1,217 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2024-01-02 13:03:20 -0300 using RuboCop version 0.49.1. +# on 2024-02-08 17:09:11 UTC using RuboCop version 1.60.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. # Offense count: 3 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. +# Include: **/*.gemspec +Gemspec/OrderedDependencies: + Exclude: + - 'departure.gemspec' + +# Offense count: 1 +# Configuration parameters: Severity, Include. +# Include: **/*.gemspec +Gemspec/RequiredRubyVersion: + Exclude: + - 'departure.gemspec' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. # SupportedStyles: leading, trailing Layout/DotPosition: Exclude: - 'spec/integration/indexes_spec.rb' +# Offense count: 6 +# This cop supports safe autocorrection (--autocorrect). +Layout/EmptyLineAfterGuardClause: + Exclude: + - 'lib/active_record/connection_adapters/for_alter.rb' + - 'lib/active_record/connection_adapters/percona_adapter.rb' + - 'lib/departure/alter_argument.rb' + - 'lib/departure/log_sanitizers/password_sanitizer.rb' + - 'lib/departure/migration.rb' + # Offense count: 4 -# Cop supports --auto-correct. -# Configuration parameters: SupportedStyles, IndentationWidth. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets -Layout/IndentArray: +Layout/FirstArrayElementIndentation: EnforcedStyle: consistent # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: Width, IgnoredPatterns. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Width, AllowedPatterns. Layout/IndentationWidth: Exclude: - 'spec/integration/indexes_spec.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. +Layout/LeadingCommentSpace: + Exclude: + - 'lib/active_record/connection_adapters/for_alter.rb' + # Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBraces: space, no_space Layout/SpaceInsideHashLiteralBraces: Exclude: - 'spec/active_record/connection_adapters/percona_adapter_spec.rb' +# Offense count: 9 +# Configuration parameters: AllowedMethods. +# AllowedMethods: enums +Lint/ConstantDefinitionInBlock: + Exclude: + - 'spec/integration/change_table_spec.rb' + - 'spec/integration/columns_spec.rb' + - 'spec/integration/data_migrations_spec.rb' + - 'spec/integration/foreign_keys_spec.rb' + - 'spec/integration/indexes_spec.rb' + - 'spec/integration/references_spec.rb' + - 'spec/integration/tables_spec.rb' + - 'spec/integration_spec.rb' + - 'spec/lhm_integration_spec.rb' + # Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. +# This cop supports safe autocorrection (--autocorrect). +Lint/RedundantCopDisableDirective: + Exclude: + - 'lib/active_record/connection_adapters/percona_adapter.rb' + - 'lib/departure/command.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Lint/SendWithMixinArgument: + Exclude: + - 'spec/spec_helper.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. Lint/UnusedMethodArgument: Exclude: - 'lib/active_record/connection_adapters/for_alter.rb' - 'spec/spec_helper.rb' # Offense count: 1 -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 123 +# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. +# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to +Naming/MethodParameterName: + Exclude: + - 'lib/active_record/connection_adapters/percona_adapter.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Security/YAMLLoad: Exclude: - 'configuration.rb' -# Offense count: 12 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: braces, no_braces, context_dependent -Style/BracesAroundHashParameters: +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols. +# SupportedStyles: inline, group +Style/AccessModifierDeclarations: Exclude: - - 'spec/fixtures/migrate/**.rb' - - 'spec/integration/**.rb' - - 'spec/lhm/adapter/add_unique_index_spec.rb' - - 'spec/lhm/adapter/remove_index_spec.rb' + - 'lib/departure/migration.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. # SupportedStyles: compact, expanded Style/EmptyMethod: Exclude: - 'spec/fixtures/migrate/0029_disable_departure.rb' +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/Encoding: + Exclude: + - 'departure.gemspec' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +Style/ExpandPathArguments: + Exclude: + - 'departure.gemspec' + - 'spec/lhm_integration_spec.rb' + - 'spec/spec_helper.rb' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/GlobalStdStream: + Exclude: + - 'lib/active_record/connection_adapters/for_alter.rb' + - 'spec/spec_helper.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/IfUnlessModifier: + Exclude: + - 'lib/active_record/connection_adapters/percona_adapter.rb' + - 'lib/departure/connection_details.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: literals, strict +Style/MutableConstant: + Exclude: + - 'lib/departure/alter_argument.rb' + +# Offense count: 2 +# Configuration parameters: AllowedMethods. +# AllowedMethods: respond_to_missing? +Style/OptionalBooleanParameter: + Exclude: + - 'lib/departure/logger.rb' + - 'lib/departure/null_logger.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantConditional: + Exclude: + - 'lib/lhm/column_with_sql.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/RedundantInterpolation: + Exclude: + - 'spec/active_record/connection_adapters/percona_adapter_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantRegexpCharacterClass: + Exclude: + - 'lib/departure/alter_argument.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Style/StderrPuts: + Exclude: + - 'lib/active_record/connection_adapters/for_alter.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Mode. +Style/StringConcatenation: + Exclude: + - 'lib/departure/dsn.rb' + # Offense count: 12 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: @@ -89,23 +222,17 @@ Style/StringLiterals: - 'spec/lhm/column_with_sql_spec.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma Style/TrailingCommaInArguments: Exclude: - 'spec/departure/runner_spec.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleForMultiline, SupportedStylesForMultiline. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma -Style/TrailingCommaInLiteral: +Style/TrailingCommaInArrayLiteral: Exclude: - 'spec/integration/data_migrations_spec.rb' - -# Offense count: 1 -# Cop supports --auto-correct. -Style/UnneededInterpolation: - Exclude: - - 'spec/active_record/connection_adapters/percona_adapter_spec.rb' diff --git a/Gemfile b/Gemfile index 19f410c9..7d8e71a3 100644 --- a/Gemfile +++ b/Gemfile @@ -3,4 +3,5 @@ source 'https://rubygems.org' gemspec gem 'codeclimate-test-reporter', '~> 1.0.3', group: :test, require: nil -gem 'rubocop', '~> 0.49.1', require: false +gem 'rubocop', '~> 1.60.2', require: false +gem 'rubocop-performance', '~> 1.20.2', require: false