From 12be29e4a16cd6b8482a0c185c47be6ea7d200e2 Mon Sep 17 00:00:00 2001 From: Jeremy Long Date: Tue, 23 Jul 2024 09:01:18 -0400 Subject: [PATCH] fix: correct percentage calculation resolves #6866 --- .../owasp/dependencycheck/data/update/NvdApiDataSource.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/org/owasp/dependencycheck/data/update/NvdApiDataSource.java b/core/src/main/java/org/owasp/dependencycheck/data/update/NvdApiDataSource.java index ea18e242e5a..69ac10b1f6a 100644 --- a/core/src/main/java/org/owasp/dependencycheck/data/update/NvdApiDataSource.java +++ b/core/src/main/java/org/owasp/dependencycheck/data/update/NvdApiDataSource.java @@ -365,8 +365,9 @@ private boolean processApi() throws UpdateException { } ctr += 1; if ((ctr % 5) == 0) { - final double percent = (double) (ctr * RESULTS_PER_PAGE) / max * 100; - LOGGER.info(String.format("Downloaded %,d/%,d (%.0f%%)", ctr * RESULTS_PER_PAGE, max, percent)); + //TODO get results per page from the API as it could adjust automatically + final double percent = (double) (ctr * resultsPerPage) / max * 100; + LOGGER.info(String.format("Downloaded %,d/%,d (%.0f%%)", ctr * resultsPerPage, max, percent)); } } final ZonedDateTime last = api.getLastUpdated();