From 2b4f46621756d4bc0ace99e6a692e05123ef64fa Mon Sep 17 00:00:00 2001 From: Nikita Volodin Date: Fri, 3 May 2024 01:55:13 -0400 Subject: [PATCH] fix(eval/latencies): generate metadata for warmup_rate This removes the requirement where we had to put `warmup_rate` value in the list of rates that we test. This speeds up the test and also allows us to test only one variant, when there is only one rate value. --- evaluation/scripts/collect-latencies.mts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/evaluation/scripts/collect-latencies.mts b/evaluation/scripts/collect-latencies.mts index c989b7ec..eb76f698 100755 --- a/evaluation/scripts/collect-latencies.mts +++ b/evaluation/scripts/collect-latencies.mts @@ -39,9 +39,9 @@ const bookinfo_variants = new Set([ ] as const) /** * Which variants to test during this run. - * Note, that there has to be more than one variant here, since with one - * variant, there is some weird behavior where each second attack fails for - * most of the requests. + * Note, that there has to be more than one variant here if we are testing more + * than one rate value. That is because with one variant, there is some weird + * behavior where each second attack fails for most of the requests. */ const test_only = new Set([ "plain", @@ -86,7 +86,7 @@ await (async function main() { ) const metadata_map = new Map>() - for (const rate of rates) { + for (const rate of new Set([warmup_rate, ...rates])) { const map = new Map() for (const variant of test_only) {