-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is the goal to be 100% compatible with axios? #14
Comments
Aside from |
|
Potentially philosophical-ish question- if there becomes 100% parity between the two libraries, why would I ever choose to use |
I doubt the end result is 100% parity, since Fetch is only just now getting progressive upload support spec'd out. The philosophical goal of this library is not to reduce the size of axios (it's not even that large). It's make it easy to move to Fetch without requiring a refactor. For folks looking to squeeze the size of their code, redaxios still includes a bunch of architectural niceties from Axios that are often unused - moving to a small purpose-built wrapper around fetch should really be the goal. |
you are jebaiting people by referring to the axios documentation. that implies this a drop in replacement |
I agree, I would state in the docs that this is not a drop-in replacement library. |
Nowhere in the readme do I state that redaxios is intended to be identical to Axios. That would make the module pointless. It doesn't make sense to replicate Axios' documentation here, because redaxios is a strict subset of its functionality. A list of compatibility notes would be better, I simply haven't had the time to write it and currently would prefer to spend that time merging the open PRs that ultimately reduce those differences. I don't think there is any readme text that would address the issue of folks believing that this is somehow a simultaneously |
well, then how does one understand what is and is not implemented? you only linked to the axios document, so that would make people assume everything is implemented. even in the readme you say |
Absolutely. My comment was not intended do bash the project or something. I did comment because in the company where I work, we choose to change
Based on those points, seems that I will prepare a PR with compatibility notes. Anyway, thank you for your time and the library. |
One part of this that is perhaps worth mentioning is that portions of the differences are just because redaxios is new, and there's still work to do. |
As of this writing some axios features are still not supported.
The text was updated successfully, but these errors were encountered: