You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the registry operator hostname setup only uses the CR name value for the hostname part, for openshift deployments and how the helm chart sets up the hostname _template.tpl#L16, the CR name is coupled with the namespace name to create the hostname.
Create getter function to receive the hostname part of the ingress address
Create hostname using the format <DevfileRegistry.Name>-<DevfileRegistry.Namespace>
Update GetDevfileRegistryIngress to couple the result of the hostname getter function and the set ingress domain DevfileRegistry.Spec.K8s.IngressDomain
Ensure integration test cases are passing
The text was updated successfully, but these errors were encountered:
Functions have been created and updated to reflect the changes. I added some unit tests for these changes and they seem to be working great.
Currently working on adding a few more cases to the unit tests and then need to integration test. The integration tests are giving me issues as the pods don't want to run properly. Working through that issue before opening a PR.
Which area/kind this issue is related to?
/area registry
Issue Description
Currently, the registry operator hostname setup only uses the CR name value for the hostname part, for openshift deployments and how the helm chart sets up the hostname _template.tpl#L16, the CR name is coupled with the namespace name to create the hostname.
The registry operator source should be changed to something of the following:
GetDevfileRegistryIngress
GetHostname
Parent Epic: #1274
Acceptance Criteria
<DevfileRegistry.Name>-<DevfileRegistry.Namespace>
GetDevfileRegistryIngress
to couple the result of the hostname getter function and the set ingress domainDevfileRegistry.Spec.K8s.IngressDomain
The text was updated successfully, but these errors were encountered: