Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement override fields under registry operator reconcile #1440

Closed
5 tasks
Tracked by #1446
michael-valdron opened this issue Feb 1, 2024 · 2 comments
Closed
5 tasks
Tracked by #1446

Implement override fields under registry operator reconcile #1440

michael-valdron opened this issue Feb 1, 2024 · 2 comments
Labels
area/registry Devfile registry for stacks and infrastructure lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Feb 1, 2024 •
edited
Loading

Which area/kind this issue is related to?

/area registry

Issue Description

With the addition of the new override fields to the DevfileRegistry CRD #1439, changes would need to be done to the reconcile procedure under the controller to have the registry operator update these fields when changes are applied.

Parent Epic: #1446

Acceptance Criteria

  • Implement update mechanism for hostnameOverride field under controller reconcile procedure
  • Implement update mechanism for nameOverride field under controller reconcile procedure
  • Implement update mechanism for fullnameOverride field under controller reconcile procedure
  • Update documentation to include usage of override fields
  • Run integration tests to verify changes
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Feb 1, 2024
This was referenced Feb 1, 2024
Closed
Open
@michael-valdron
Copy link
Member Author

Parent issue updated to #1446.

@Jdubrick Jdubrick moved this to Refinement in Devfile Project Feb 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label May 8, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Sep 28, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2024
@github-project-automation github-project-automation bot moved this from Refinement to Done ✅ in Devfile Project Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/registry Devfile registry for stacks and infrastructure lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-valdron