Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry operator app name truncating #1442

Closed
2 tasks done
Tracked by #1446
michael-valdron opened this issue Feb 1, 2024 · 4 comments
Closed
2 tasks done
Tracked by #1446

Registry operator app name truncating #1442

michael-valdron opened this issue Feb 1, 2024 · 4 comments
Assignees
@michael-valdron
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Feb 1, 2024 •
edited
Loading

Which area/kind this issue is related to?

/area registry

Issue Description

When setting the app names, the devfile registry helm chart truncates strings used for the names to be 63 characters in length:

This is because some Kubernetes name fields are limited to this (by the DNS naming spec).

Currently, the registry operator does not truncate the app name to suite this limitation.

Parent Epic: #1446

Acceptance Criteria

  • Update the app name and full app name getters to perform string truncating to 63 characters max
  • Update any test cases involving the app name or full app name to consider the truncated names
@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Feb 1, 2024
This was referenced Feb 1, 2024
Closed
Open
@michael-valdron
Copy link
Member Author

Parent issue updated to #1446.

@Jdubrick Jdubrick moved this to Refinement in Devfile Project Feb 29, 2024
@michael-valdron michael-valdron moved this from Refinement to In Progress 🚧 in Devfile Project Apr 11, 2024
@michael-valdron michael-valdron self-assigned this Apr 11, 2024
@michael-valdron michael-valdron mentioned this issue Apr 11, 2024
Merged
3 tasks
@michael-valdron
Copy link
Member Author

PR for #1441 resolves this issue as well.

@michael-valdron michael-valdron moved this from In Progress 🚧 to In Review 👀 in Devfile Project Apr 12, 2024
@michael-valdron
Copy link
Member Author

PR is ready for review: devfile/registry-operator#86

@michael-valdron
Copy link
Member Author

Resolved by devfile/registry-operator#86

@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-valdron michael-valdron

Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michael-valdron