Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing a team for reviewer throws an error #54

Open
1 of 5 tasks
EmiiFont opened this issue Aug 20, 2021 · 6 comments
Open
1 of 5 tasks

passing a team for reviewer throws an error #54

EmiiFont opened this issue Aug 20, 2021 · 6 comments

Comments

@EmiiFont
Copy link

EmiiFont commented Aug 20, 2021

📝 Brief description

Hi, i'm trying to add the team as a reviewer but is not picking it up

I've tried reviewer: "team-prs" reviewer: "/team-prs" reviewer: "@org/team-prs" reviewer: "org/team-prs"

and it shows an error Error requesting reviewer: Unprocessable Entity (HTTP 422)

expected to pick up one of the members of the team to review

any ideas?

⚠️ Checklist

  • Provided a clear and concise description of what the issue is.
  • Given a clear and concise description of what is expected.
  • Proposed a clear and concise description of any alternative solutions or other features.
  • Added any other context or screenshots about the feature request.
  • Associated pull request has been already created and link was provided.

Check CONTRIBUTING.md and CODE_OF_CONDUCT.md for more information

@ChristophShyper
Copy link
Member

Hi!
It appears to be a bug in hub binary.
I checked it running directly via CLI and got the same errors:

Error creating pull request: Unprocessable Entity (HTTP 422)
You can't perform that action at this time.

I've created issue ticket for them to address the problem mislav/hub#2825

Until it's fixed I can suggest different solution, which I'm always using - define CODEOWNERS file and then team would be automatically added based on the configuration.

@oerp-odoo
Copy link

@ChristophShyper does it actually work with CODEOWNERS? It never assigns anything, even though github says file is correct.

@ChristophShyper
Copy link
Member

@oerp-odoo I'm using it for many years, even before actions.
Do you have the default path * defined there?

@oerp-odoo
Copy link

Oh, I thought you can have just user specified and it will work. Though I don't understand why github then shows file as valid. I would expect to see some info that its not valid. Thanks, I will try it.

@oerp-odoo
Copy link

@ChristophShyper its working nicely, thanks. I can even use teams to auto assign from there randomly, which is nice.

@ChristophShyper
Copy link
Member

@oerp-odoo Great to hear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants