Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the liquidchart display on #1168

Open
ollibowers opened this issue Jul 30, 2024 · 1 comment
Open

fix the liquidchart display on #1168

ollibowers opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
📝 bug 🐛 Something isn't working 👤 closed for help 👥 Closed to external help, team only 📝 dependencies 📦 Pull requests that update a dependency file 🫣 331 🤫 Is only in scope within the current 331 branch

Comments

@ollibowers
Copy link
Collaborator

ollibowers commented Jul 30, 2024

On dev, liquidchart slowly fills up :)
On 331, it laggily fills up :(

This seems to be due to a antd charts upgrade we did at the start of the year. I have investigated this heavily before, and struggled to find a fix (the library docs are not in english, nor are the typings).

We must restore this behaviour. To do so, you have 3 options:

  • try update the charts library again and see if it has gotten better...
  • try downgrade back to the old charts library version
  • try find a standalone package that gives us a LiquidChart with similar functionality (preferrable, and I am aware some float around)
@ollibowers ollibowers added 📝 bug 🐛 Something isn't working 📝 dependencies 📦 Pull requests that update a dependency file 👤 closed for help 👥 Closed to external help, team only 🫣 331 🤫 Is only in scope within the current 331 branch labels Jul 30, 2024
@lhvy
Copy link
Contributor

lhvy commented Aug 18, 2024

This one looks really stable: npm, demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 bug 🐛 Something isn't working 👤 closed for help 👥 Closed to external help, team only 📝 dependencies 📦 Pull requests that update a dependency file 🫣 331 🤫 Is only in scope within the current 331 branch
Projects
None yet
Development

No branches or pull requests

3 participants