Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in sim_cartesian_dmp.py example #69

Open
cmower opened this issue Feb 3, 2025 · 1 comment
Open

Possible bug in sim_cartesian_dmp.py example #69

cmower opened this issue Feb 3, 2025 · 1 comment

Comments

@cmower
Copy link
Contributor

cmower commented Feb 3, 2025

hi @AlexanderFabisch I think there is a potential bug in the example

dmp = DMP(n_dims=7, execution_time=execution_time, dt=dt,
n_weights_per_dim=10, int_dt=0.01, p_gain=2.5)

should this not be CartesianDMP?

@cmower cmower changed the title Possible bug in example Possible bug in sim_cartesian_dmp.py example Feb 3, 2025
@AlexanderFabisch
Copy link
Member

Given that the documentation says "A normal DMP is used to represent a Cartesian trajectory given by positions and quaternions." I think that this was actually done on purpose to see how well it works. Of course, it is not the "correct" way to do it. I am open for suggestions to improve the example. Maybe a comparison between the two DMPs would be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants