Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintaining a list of packages that needs to be ignored by default #22

Open
Hemric opened this issue Apr 22, 2020 · 0 comments
Open

Maintaining a list of packages that needs to be ignored by default #22

Hemric opened this issue Apr 22, 2020 · 0 comments

Comments

@Hemric
Copy link

Hemric commented Apr 22, 2020

  • bug report? no
  • feature request? yes

Description

After having installed this package on my project and successfully passed tests. I end up catching (fortunately) an issue with a business important package stripe-php during e2e testing. The cleaner removes a folder called "data" which contains a "ca-certificates.crt" used by the library when actually calling the Stripe API ! The exception thrown end up notifying a Network Error that is uneasy to debug.

This could have been launched to production with a less rigorous testing and impact website badly.

Maybe we could put at least a feature that detects sensitive packages that needs to be ignored by default. And notifying user during install.

Steps To Reproduce

  • require stripe/stripe-php
  • require dg/composer-cleaner
  • Set up Stripe and attempt a createCustomer call for example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant