pitch with no accidental is different from pitch with natural accidental

[reeceyang]

for example, a <music21.pitch.Pitch C5> with accidental <music21.pitch.Accidental natural> does not equal a <music21.pitch.Pitch C5> with accidental None.

fixing this might require updating the subclasses (maybe when parsing the musicxml, if a pitch has a natural accidental then set the accidental to None instead)

there might be a similar issue with enharmonic notes.

[NamelessChamber]

Hmm, if I understand you correctly we actually want those two pitches to show up differently because a pitch with a natural sign is going to be one of those extra pitches outside of the normal behavior of the makam.

[reeceyang]

I found this in the music21 documentation:

Pitches should contain information about what absolute pitch they are, so a B note in Bb major would have a pitch with a 'flat' accidental. The issue comes from when we have a F pitch with an accidental of None and a F pitch with a 'natural' accidental—these are supposed to be the same pitch.

[reeceyang]

I've overrided xmlToPitch to OttomanMusicMeasureParser to convert all natural accidentals to None (this happens at the end of the function and is indicated with a comment). This is definitely a band-aid fix, so I'm leaving this issue open.

xmlToPitch is also the function where we would want to add in microtone parsing.