Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DH Audit - Time Series Data #81

Open
christianscarlett opened this issue Jan 11, 2022 · 1 comment
Open

DH Audit - Time Series Data #81

christianscarlett opened this issue Jan 11, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@christianscarlett
Copy link
Contributor

christianscarlett commented Jan 11, 2022

Time Series Data

Assessment

This tool is very easy to get started on and the sunrise demo dataset was very helpful. There’s a very clear relation from data -> sound, and the generated graphs illustrate this well. I think the biggest thing that needs improvement on this tool is the parameter inputs.

Ideas

I’m not sure what Multiplier and Offset do, nor am I totally sure about Base Frequency. Perhaps we could put a tooltip here or find better names for them.

The “Map numbers to note” should probably be labeled “Bin pitches” or something similar—not totally sure what this checkbox does.

The ADSR makes things much more listenable—can we streamline the UI for this and integrate it into other tools as well? For the UI, I’m thinking of sliders or some kind of picture showing the envelope.

We should have a way to “reset” the tool without refreshing the page.

@christianscarlett christianscarlett added the enhancement New feature or request label Jan 11, 2022
@ryaanahmed
Copy link
Member

We don't need the "instrument" tools for this module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants