From ac54e9d09601ee9a2ebe2e8530ca55d37a837b31 Mon Sep 17 00:00:00 2001 From: Daniel Thamdrup Date: Wed, 7 Feb 2024 16:49:32 +0100 Subject: [PATCH] opinions & linting Signed-off-by: Daniel Thamdrup --- .github/ISSUE_TEMPLATE/bug_report.yml | 2 + .github/ISSUE_TEMPLATE/feature_request.yml | 2 + .github/dependabot.yml | 2 + .github/workflows/Android.yml | 82 ++++----- .github/workflows/Linux_aarch64.yml | 159 +++++++++--------- .github/workflows/Linux_x86.yml | 154 +++++++++-------- .github/workflows/Linux_x86_64.yml | 142 ++++++++-------- .github/workflows/Linux_x86_64_SDL1.yml | 109 +++++++----- .github/workflows/Linux_x86_64_test.yml | 68 +++++--- .github/workflows/PS4.yml | 73 ++++---- .github/workflows/Windows9x_MinGW.yml | 92 +++++----- .github/workflows/Windows_MSVC_x64.yml | 67 ++++---- .github/workflows/Windows_MinGW_x64.yml | 141 ++++++++++------ .github/workflows/Windows_MinGW_x86.yml | 78 ++++++--- .github/workflows/cache-cleanup.yml | 5 +- .github/workflows/clang-format-check.yml | 38 +++-- .github/workflows/iOS.yml | 90 +++++----- .github/workflows/macOS_x86_64.yml | 80 ++++----- .github/workflows/miyoo_mini_release.yml | 77 +++++---- .github/workflows/opendingux_release.yml | 143 ++++++++-------- .github/workflows/retrofw_release.yml | 74 ++++---- .../workflows/s390x_qemu_big_endian_tests.yml | 54 +++--- .github/workflows/src_dist_release.yml | 129 ++++++++------ .github/workflows/translations.yml | 29 ++-- .github/workflows/xbox_nxdk.yml | 99 ++++++----- .github/workflows/xbox_one.yml | 96 +++++------ .yamllint | 31 ++++ codecov.yml | 10 +- 28 files changed, 1193 insertions(+), 933 deletions(-) create mode 100644 .yamllint diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 9c2607d31fc..454eb82eef1 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,3 +1,4 @@ +--- name: Bug report description: Create a report to help us improve title: "[Issue Report]: " @@ -69,3 +70,4 @@ body: attributes: label: Additional context placeholder: Any other context about the problem here (screenshots, videos, code blocks, etc.). +... diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 3ce1052d6d7..2b291e0de49 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,3 +1,4 @@ +--- name: Feature Request description: Request a feature or improvement. title: "[Feature Request]: " @@ -21,3 +22,4 @@ body: placeholder: A clear and concise description of the desired feature/change. validations: required: true +... diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 01b3ca4ac0a..7c57c882c07 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,6 +1,8 @@ +--- version: 2 updates: - package-ecosystem: github-actions directory: '/' schedule: interval: weekly +... diff --git a/.github/workflows/Android.yml b/.github/workflows/Android.yml index 8352e14d581..f9fe328c6d4 100644 --- a/.github/workflows/Android.yml +++ b/.github/workflows/Android.yml @@ -1,6 +1,7 @@ +--- name: Android -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,10 +9,11 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -21,39 +23,43 @@ jobs: build: runs-on: ubuntu-latest steps: - - name: Install gettext - run: sudo apt-get update && sudo apt-get install -y gettext - - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: set up JDK 17 - uses: actions/setup-java@v4 - with: - java-version: '17' - distribution: 'adopt' - cache: gradle - - - name: Cache CMake build folder - uses: actions/cache@v4 - with: - path: android-project/app/.cxx - key: ${{ github.workflow }}-v4-${{ github.sha }} - restore-keys: ${{ github.workflow }}-v4- - - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: cd android-project && ./gradlew assembleDebug - - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-debug.apk - path: android-project/app/build/outputs/apk/debug/app-debug.apk - - - name: Clean up artifacts - run: rm -rf android-project/app/build/outputs + - name: Install gettext + run: | + apt-get update + apt-get install -y \ + gettext + + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: set up JDK 17 + uses: actions/setup-java@v4 + with: + java-version: '17' + distribution: 'adopt' + cache: gradle + + - name: Cache CMake build folder + uses: actions/cache@v4 + with: + path: android-project/app/.cxx + key: ${{ github.workflow }}-v4-${{ github.sha }} + restore-keys: ${{ github.workflow }}-v4- + + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: cd android-project && ./gradlew assembleDebug + + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-debug.apk + path: android-project/app/build/outputs/apk/debug/app-debug.apk + + - name: Clean up artifacts + run: rm -rf android-project/app/build/outputs +... diff --git a/.github/workflows/Linux_aarch64.yml b/.github/workflows/Linux_aarch64.yml index 1226f49f9cf..bbc63448c62 100644 --- a/.github/workflows/Linux_aarch64.yml +++ b/.github/workflows/Linux_aarch64.yml @@ -1,6 +1,7 @@ +--- name: Linux AArch64 (aarch64-linux-gnu) -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -14,9 +15,6 @@ on: - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -27,88 +25,95 @@ jobs: build: runs-on: ubuntu-20.04 steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - # Work around the somewhat broken packages in the GitHub Actions Ubuntu 20.04 image. - # https://github.com/actions/runner-images/issues/4620#issuecomment-981333260 - - name: Work around broken packages - run: sudo apt-get -y install --allow-downgrades libpcre2-8-0=10.34-7 + # Work around the somewhat broken packages in the GitHub Actions Ubuntu 20.04 image. + # https://github.com/actions/runner-images/issues/4620#issuecomment-981333260 + - name: Work around broken packages + run: sudo apt-get -y install --allow-downgrades libpcre2-8-0=10.34-7 - - name: Add clang repo - run: | - wget -qO- https://apt.llvm.org/llvm-snapshot.gpg.key | sudo tee /etc/apt/trusted.gpg.d/apt.llvm.org.asc - sudo tee /etc/apt/sources.list.d/clang.list < - sudo apt-get update && - sudo apt-get install -y cmake file g++ git libfmt-dev libsdl1.2-dev libsodium-dev libpng-dev libbz2-dev rpm smpq - - - name: Cache CMake build folder - uses: actions/cache@v4 - with: - path: build - key: ${{ github.workflow }}-v2-${{ github.sha }} - restore-keys: ${{ github.workflow }}-v2- - - - name: Configure CMake - shell: bash - working-directory: ${{github.workspace}} - # Disable LTO to work around an ICE in gcc11 - run: cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTING=OFF -DCPACK=ON -DUSE_SDL1=ON -DDISCORD_INTEGRATION=ON -DDISABLE_LTO=ON - - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: cmake --build build -j $(nproc) --target package - - - name: Package - run: Packaging/nix/LinuxReleasePackaging.sh - - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx_linux_x86_64_SDL1.tar.xz - path: devilutionx.tar.xz - - - name: Clean up artifacts - run: rm -rf build/_CPack_Packages build/package build/*.deb build/*.rpm build/*.appimage build/*.tar.xz + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + cmake \ + file \ + g++ \ + git \ + libfmt-dev \ + libsdl1.2-dev \ + libsodium-dev \ + libpng-dev \ + libbz2-dev \ + rpm \ + smpq + + - name: Cache CMake build folder + uses: actions/cache@v4 + with: + path: build + key: ${{ github.workflow }}-v2-${{ github.sha }} + restore-keys: ${{ github.workflow }}-v2- + + - name: Configure CMake + shell: bash + working-directory: ${{github.workspace}} + # Disable LTO to work around an ICE in gcc11 + run: | + cmake \ + -S . \ + -B build \ + -D CMAKE_BUILD_TYPE=RelWithDebInfo \ + -D BUILD_TESTING=OFF \ + -D CPACK=ON \ + -D USE_SDL1=ON \ + -D DISCORD_INTEGRATION=ON \ + -D DISABLE_LTO=ON + + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: cmake --build build -j $(nproc) --target package + + - name: Package + run: Packaging/nix/LinuxReleasePackaging.sh + + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx_linux_x86_64_SDL1.tar.xz + path: devilutionx.tar.xz + + - name: Clean up artifacts + run: rm -rf build/_CPack_Packages build/package build/*.deb build/*.rpm build/*.appimage build/*.tar.xz +... diff --git a/.github/workflows/Linux_x86_64_test.yml b/.github/workflows/Linux_x86_64_test.yml index 7218c010558..7cde6b2451c 100644 --- a/.github/workflows/Linux_x86_64_test.yml +++ b/.github/workflows/Linux_x86_64_test.yml @@ -1,6 +1,7 @@ +--- name: Linux x64 Tests -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,7 +9,7 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' @@ -20,34 +21,45 @@ concurrency: jobs: build: - runs-on: ubuntu-22.04 - + runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Install dependencies - run: | - sudo apt-get update -y - sudo apt-get install -y cmake curl g++ git lcov libgtest-dev libgmock-dev libfmt-dev libsdl2-dev libsodium-dev libpng-dev libbz2-dev wget - - name: Cache CMake build folder - uses: actions/cache@v4 - with: - path: build - key: ${{ github.workflow }}-v1-${{ github.sha }} - restore-keys: ${{ github.workflow }}-v1- + - name: Install dependencies + run: | + apt-get update -y + apt-get install -y \ + cmake \ + curl \ + g++ \ + git \ + lcov \ + libgtest-dev \ + libgmock-dev \ + libfmt-dev \ + libsdl2-dev \ + libsodium-dev \ + libpng-dev \ + libbz2-dev \ + wget + - name: Cache CMake build folder + uses: actions/cache@v4 + with: + path: build + key: ${{ github.workflow }}-v1-${{ github.sha }} + restore-keys: ${{ github.workflow }}-v1- - - name: Build tests - run: | - cmake -S. -Bbuild -DENABLE_CODECOVERAGE=ON - wget -nc https://github.com/diasurgical/devilutionx-assets/releases/download/v2/spawn.mpq -P build - cmake --build build -j $(nproc) + - name: Build tests + run: | + cmake -S. -Bbuild -DENABLE_CODECOVERAGE=ON + wget -nc https://github.com/diasurgical/devilutionx-assets/releases/download/v2/spawn.mpq -P build + cmake --build build -j $(nproc) - - name: Run tests - run: cd build && ctest --output-on-failure + - name: Run tests + run: cd build && ctest --output-on-failure - - name: Upload results - uses: codecov/codecov-action@v4 - with: - gcov: true + - name: Upload results + uses: codecov/codecov-action@v4 +... diff --git a/.github/workflows/PS4.yml b/.github/workflows/PS4.yml index a1ef66c44f2..b0ec13fbb7f 100644 --- a/.github/workflows/PS4.yml +++ b/.github/workflows/PS4.yml @@ -1,6 +1,7 @@ +--- name: PS4 -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -14,9 +15,7 @@ on: - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -24,38 +23,44 @@ concurrency: jobs: ps4: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y wget cmake git gettext smpq && - wget https://github.com/PacBrew/pacbrew-pacman/releases/download/v1.1/pacbrew-pacman-1.1.deb && - sudo dpkg -i pacbrew-pacman-1.1.deb && sudo pacbrew-pacman -Sy && - sudo pacbrew-pacman --noconfirm -S ps4-openorbis ps4-openorbis-portlibs && - echo "#include " | sudo tee /opt/pacbrew/ps4/openorbis/include/sys/endian.h + - name: Create Build Environment + run: | + apt-get update && + apt-get install -y \ + wget \ + cmake \ + git \ + gettext \ + smpq && + wget https://github.com/PacBrew/pacbrew-pacman/releases/download/v1.1/pacbrew-pacman-1.1.deb && + dpkg -i pacbrew-pacman-1.1.deb && sudo pacbrew-pacman -Sy && + pacbrew-pacman --noconfirm -S ps4-openorbis ps4-openorbis-portlibs && + echo "#include " | tee /opt/pacbrew/ps4/openorbis/include/sys/endian.h - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: Packaging/ps4/build.sh + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: Packaging/ps4/build.sh - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-ps4.pkg - path: build-ps4/devilutionx.pkg + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-ps4.pkg + path: build-ps4/devilutionx.pkg - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - asset_name: devilutionx-ps4.pkg - file: build-ps4/devilutionx.pkg - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + asset_name: devilutionx-ps4.pkg + file: build-ps4/devilutionx.pkg + overwrite: true +... diff --git a/.github/workflows/Windows9x_MinGW.yml b/.github/workflows/Windows9x_MinGW.yml index 8fafa473591..93ad14b96cb 100644 --- a/.github/workflows/Windows9x_MinGW.yml +++ b/.github/workflows/Windows9x_MinGW.yml @@ -1,6 +1,7 @@ +--- name: Windows 9x MinGW -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,15 +9,12 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -25,42 +23,60 @@ concurrency: jobs: build: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y cmake gcc-mingw-w64-i686 g++-mingw-w64-i686 mingw-w64-tools libz-mingw-w64-dev gettext dpkg-dev wget git sudo smpq && - sudo rm /usr/i686-w64-mingw32/lib/libz.dll.a && - sudo Packaging/windows/mingw9x-prep.sh + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Configure CMake - shell: bash - working-directory: ${{github.workspace}} - run: cmake -S. -Bbuild-windows9x -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCPACK=ON -DCMAKE_TOOLCHAIN_FILE=../CMake/platforms/mingw9x.toolchain.cmake -DTARGET_PLATORM=windows9x + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + cmake \ + gcc-mingw-w64-i686 \ + g++-mingw-w64-i686 \ + mingw-w64-tools \ + libz-mingw-w64-dev \ + gettext \ + dpkg-dev \ + wget \ + git \ + smpq + rm /usr/i686-w64-mingw32/lib/libz.dll.a + Packaging/windows/mingw9x-prep.sh - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: | - cmake --build build-windows9x -j $(nproc) --target package - mv build-windows9x/devilutionx.zip devilutionx-win9x.zip + - name: Configure CMake + shell: bash + working-directory: ${{github.workspace}} + run: | + cmake \ + -S . \ + -B build-windows9x \ + -D CMAKE_BUILD_TYPE=Release \ + -D BUILD_TESTING=OFF \ + -D CPACK=ON \ + -D CMAKE_TOOLCHAIN_FILE=../CMake/platforms/mingw9x.toolchain.cmake \ + -D TARGET_PLATORM=windows9x - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - path: devilutionx-win9x.zip + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: | + cmake --build build-windows9x -j $(nproc) --target package + mv build-windows9x/devilutionx.zip devilutionx-win9x.zip - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: devilutionx-win9x.zip - overwrite: true + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + path: devilutionx-win9x.zip + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: devilutionx-win9x.zip + overwrite: true +... diff --git a/.github/workflows/Windows_MSVC_x64.yml b/.github/workflows/Windows_MSVC_x64.yml index d3168dce8c8..9ca4d689cf5 100644 --- a/.github/workflows/Windows_MSVC_x64.yml +++ b/.github/workflows/Windows_MSVC_x64.yml @@ -1,6 +1,7 @@ +--- name: Windows MSVC x64 -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,10 +9,11 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' + workflow_dispatch: permissions: contents: write @@ -28,43 +30,43 @@ jobs: build: runs-on: windows-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: ccache - uses: hendrikmuhs/ccache-action@v1.2 + - name: ccache + uses: hendrikmuhs/ccache-action@v1.2 - - name: Install latest CMake - uses: lukka/get-cmake@latest + - name: Install latest CMake + uses: lukka/get-cmake@latest - - name: Restore or setup vcpkg - uses: lukka/run-vcpkg@v11.4 - with: - vcpkgGitCommitId: '16ee2ecb31788c336ace8bb14c21801efb6836e4' + - name: Restore or setup vcpkg + uses: lukka/run-vcpkg@v11.4 + with: + vcpkgGitCommitId: '16ee2ecb31788c336ace8bb14c21801efb6836e4' - - name: Fetch test data - run: | - mkdir build-ninja-vcpkg-relwithdebinfo - Invoke-WebRequest -Uri "https://github.com/diasurgical/devilutionx-assets/releases/download/v2/spawn.mpq" -OutFile "build-ninja-vcpkg-relwithdebinfo/spawn.mpq" -Resume + - name: Fetch test data + run: | + mkdir build-ninja-vcpkg-relwithdebinfo + Invoke-WebRequest -Uri "https://github.com/diasurgical/devilutionx-assets/releases/download/v2/spawn.mpq" -OutFile "build-ninja-vcpkg-relwithdebinfo/spawn.mpq" -Resume - - name: Get CMakePresets.json - run: cp Packaging/windows/CMakePresets.json . + - name: Get CMakePresets.json + run: cp Packaging/windows/CMakePresets.json . - - name: Run CMake consuming CMakePresets.json and vcpkg.json by mean of vcpkg. - uses: lukka/run-cmake@v10 - with: - configurePreset: 'ninja-vcpkg-relwithdebinfo' - buildPreset: 'ninja-vcpkg-relwithdebinfo' - testPreset: 'ninja-vcpkg-relwithdebinfo' + - name: Run CMake consuming CMakePresets.json and vcpkg.json by mean of vcpkg. + uses: lukka/run-cmake@v10 + with: + configurePreset: 'ninja-vcpkg-relwithdebinfo' + buildPreset: 'ninja-vcpkg-relwithdebinfo' + testPreset: 'ninja-vcpkg-relwithdebinfo' - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx.exe - path: | + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx.exe + path: | build-ninja-vcpkg-relwithdebinfo/devilutionx.exe build-ninja-vcpkg-relwithdebinfo/bz2.dll build-ninja-vcpkg-relwithdebinfo/fmt.dll @@ -73,3 +75,4 @@ jobs: build-ninja-vcpkg-relwithdebinfo/SDL2.dll build-ninja-vcpkg-relwithdebinfo/SDL2_image.dll build-ninja-vcpkg-relwithdebinfo/zlib1.dll +... diff --git a/.github/workflows/Windows_MinGW_x64.yml b/.github/workflows/Windows_MinGW_x64.yml index aba82bd212c..d121d12e25e 100644 --- a/.github/workflows/Windows_MinGW_x64.yml +++ b/.github/workflows/Windows_MinGW_x64.yml @@ -1,6 +1,7 @@ +--- name: Windows MinGW x64 -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,10 +9,11 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -19,65 +21,92 @@ concurrency: jobs: build: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y cmake gcc-mingw-w64-x86-64 g++-mingw-w64-x86-64 pkg-config-mingw-w64-x86-64 libz-mingw-w64-dev gettext dpkg-dev wget git sudo smpq && - sudo rm /usr/x86_64-w64-mingw32/lib/libz.dll.a && - sudo Packaging/windows/mingw-prep64.sh + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + cmake \ + gcc-mingw-w64-x86-64 \ + g++-mingw-w64-x86-64 \ + pkg-config-mingw-w64-x86-64 \ + libz-mingw-w64-dev \ + gettext \ + dpkg-dev \ + wget \ + git \ + smpq + rm /usr/x86_64-w64-mingw32/lib/libz.dll.a + Packaging/windows/mingw-prep64.sh - - name: Configure CMake - shell: bash - working-directory: ${{github.workspace}} - run: cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTING=OFF -DCPACK=ON -DCMAKE_TOOLCHAIN_FILE=../CMake/platforms/mingwcc64.toolchain.cmake -DDEVILUTIONX_SYSTEM_BZIP2=OFF -DDEVILUTIONX_STATIC_LIBSODIUM=ON -DDISCORD_INTEGRATION=ON -DSCREEN_READER_INTEGRATION=ON + - name: Configure CMake + shell: bash + working-directory: ${{github.workspace}} + run: | + cmake \ + -S . \ + -B build \ + -D CMAKE_BUILD_TYPE=RelWithDebInfo \ + -D BUILD_TESTING=OFF \ + -D CPACK=ON \ + -D CMAKE_TOOLCHAIN_FILE=../CMake/platforms/mingwcc64.toolchain.cmake \ + -D DEVILUTIONX_SYSTEM_BZIP2=OFF \ + -D DEVILUTIONX_STATIC_LIBSODIUM=ON \ + -D DISCORD_INTEGRATION=ON \ + -D SCREEN_READER_INTEGRATION=ON - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: cmake --build build -j $(nproc) --target package + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: cmake --build build -j $(nproc) --target package - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx_x64.zip - path: build/devilutionx.zip + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx_x64.zip + path: build/devilutionx.zip - - name: Move artifacts to new folder and split exe and other data into two folders - if: ${{ !env.ACT && github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'diasurgical/devilutionX'}} - working-directory: ${{github.workspace}} - shell: bash - run: mkdir artifacts_dir && unzip build/devilutionx.zip -d artifacts_dir && mkdir artifacts_dir/exe_dir && mv artifacts_dir/devilutionx/devilutionx.exe artifacts_dir/exe_dir && zip -m artifacts_dir/exe_dir/build.zip artifacts_dir/exe_dir/devilutionx.exe + - name: Move artifacts to new folder and split exe and other data into two folders + if: ${{ !env.ACT && github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'diasurgical/devilutionX'}} + working-directory: ${{github.workspace}} + shell: bash + run: | + mkdir artifacts_dir + unzip build/devilutionx.zip -d artifacts_dir + mkdir artifacts_dir/exe_dir + mv artifacts_dir/devilutionx/devilutionx.exe artifacts_dir/exe_dir + zip -m artifacts_dir/exe_dir/build.zip artifacts_dir/exe_dir/devilutionx.exe - - name: Pushes DLLs and devilutionx.mpq to another repository - if: ${{ !env.ACT && github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'diasurgical/devilutionX' }} - uses: cpina/github-action-push-to-another-repository@main - env: - SSH_DEPLOY_KEY: ${{ secrets.SSH_DEPLOY_KEY }} - with: - source-directory: artifacts_dir/devilutionx/ - destination-github-username: 'artifacts-storage' - destination-repository-name: 'devilutionx-artifacts' - target-directory: data - commit-message: "[DATA] ${{ github.event.head_commit.message }}" - target-branch: master + - name: Pushes DLLs and devilutionx.mpq to another repository + if: ${{ !env.ACT && github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'diasurgical/devilutionX' }} + uses: cpina/github-action-push-to-another-repository@main + env: + SSH_DEPLOY_KEY: ${{ secrets.SSH_DEPLOY_KEY }} + with: + source-directory: artifacts_dir/devilutionx/ + destination-github-username: 'artifacts-storage' + destination-repository-name: 'devilutionx-artifacts' + target-directory: data + commit-message: "[DATA] ${{ github.event.head_commit.message }}" + target-branch: master - - name: Pushes exe to another repository - if: ${{ !env.ACT && github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'diasurgical/devilutionX' }} - uses: cpina/github-action-push-to-another-repository@main - env: - SSH_DEPLOY_KEY: ${{ secrets.SSH_DEPLOY_KEY }} - with: - source-directory: artifacts_dir/exe_dir - destination-github-username: 'artifacts-storage' - destination-repository-name: 'devilutionx-artifacts' - target-directory: ${{ github.sha }} - commit-message: "[EXE] ${{ github.event.head_commit.message }}" - target-branch: master + - name: Pushes exe to another repository + if: ${{ !env.ACT && github.ref == 'refs/heads/master' && github.event_name != 'pull_request' && github.repository == 'diasurgical/devilutionX' }} + uses: cpina/github-action-push-to-another-repository@main + env: + SSH_DEPLOY_KEY: ${{ secrets.SSH_DEPLOY_KEY }} + with: + source-directory: artifacts_dir/exe_dir + destination-github-username: 'artifacts-storage' + destination-repository-name: 'devilutionx-artifacts' + target-directory: ${{ github.sha }} + commit-message: "[EXE] ${{ github.event.head_commit.message }}" + target-branch: master +... diff --git a/.github/workflows/Windows_MinGW_x86.yml b/.github/workflows/Windows_MinGW_x86.yml index d35f24eb957..4f5b04ea67c 100644 --- a/.github/workflows/Windows_MinGW_x86.yml +++ b/.github/workflows/Windows_MinGW_x86.yml @@ -1,6 +1,7 @@ +--- name: Windows MinGW x86 -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,10 +9,11 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -19,33 +21,55 @@ concurrency: jobs: build: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt update && - sudo apt install -y cmake gcc-mingw-w64-i686 g++-mingw-w64-i686 pkg-config-mingw-w64-i686 libz-mingw-w64-dev gettext dpkg-dev wget git sudo smpq && - sudo rm /usr/i686-w64-mingw32/lib/libz.dll.a && - sudo Packaging/windows/mingw-prep.sh + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + cmake \ + gcc-mingw-w64-i686 \ + g++-mingw-w64-i686 \ + pkg-config-mingw-w64-i686 \ + libz-mingw-w64-dev \ + gettext \ + dpkg-dev \ + wget \ + git \ + smpq + rm /usr/i686-w64-mingw32/lib/libz.dll.a + Packaging/windows/mingw-prep.sh - - name: Configure CMake - shell: bash - working-directory: ${{github.workspace}} - run: cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBUILD_TESTING=OFF -DCPACK=ON -DCMAKE_TOOLCHAIN_FILE=../CMake/platforms/mingwcc.toolchain.cmake -DDEVILUTIONX_SYSTEM_BZIP2=OFF -DDEVILUTIONX_STATIC_LIBSODIUM=ON -DDISCORD_INTEGRATION=ON -DSCREEN_READER_INTEGRATION=ON + - name: Configure CMake + shell: bash + working-directory: ${{github.workspace}} + run: | + cmake \ + -S . \ + -B build \ + -D CMAKE_BUILD_TYPE=RelWithDebInfo \ + -D BUILD_TESTING=OFF \ + -D CPACK=ON \ + -D CMAKE_TOOLCHAIN_FILE=../CMake/platforms/mingwcc.toolchain.cmake \ + -D DEVILUTIONX_SYSTEM_BZIP2=OFF \ + -D DEVILUTIONX_STATIC_LIBSODIUM=ON \ + -D DISCORD_INTEGRATION=ON \ + -D SCREEN_READER_INTEGRATION=ON - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: cmake --build build -j $(nproc) --target package + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: cmake --build build -j $(nproc) --target package - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx_x86.zip - path: build/devilutionx.zip + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx_x86.zip + path: build/devilutionx.zip +... diff --git a/.github/workflows/cache-cleanup.yml b/.github/workflows/cache-cleanup.yml index 6664b4c2f0d..26d85023b99 100644 --- a/.github/workflows/cache-cleanup.yml +++ b/.github/workflows/cache-cleanup.yml @@ -1,5 +1,7 @@ +--- name: Delete cache for a closed Pull Request -on: + +on: # yamllint disable-line rule:truthy pull_request: types: - closed @@ -31,3 +33,4 @@ jobs: echo "Done" env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} +... diff --git a/.github/workflows/clang-format-check.yml b/.github/workflows/clang-format-check.yml index 9ade7f79944..112bd779e37 100644 --- a/.github/workflows/clang-format-check.yml +++ b/.github/workflows/clang-format-check.yml @@ -1,6 +1,7 @@ +--- name: clang-format check -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,7 +9,7 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' @@ -21,21 +22,22 @@ jobs: formatting-check: runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Formatting Check (Source) - uses: jidicula/clang-format-action@v4.11.0 - with: - clang-format-version: '13' - check-path: 'Source' - fallback-style: 'webkit' + - name: Formatting Check (Source) + uses: jidicula/clang-format-action@v4.11.0 + with: + clang-format-version: '13' + check-path: 'Source' + fallback-style: 'webkit' - - name: Formatting Check (test) - uses: jidicula/clang-format-action@v4.11.0 - with: - clang-format-version: '13' - check-path: 'test' - fallback-style: 'webkit' + - name: Formatting Check (test) + uses: jidicula/clang-format-action@v4.11.0 + with: + clang-format-version: '13' + check-path: 'test' + fallback-style: 'webkit' +... diff --git a/.github/workflows/iOS.yml b/.github/workflows/iOS.yml index 7ca2220066c..e358fb2d6d8 100644 --- a/.github/workflows/iOS.yml +++ b/.github/workflows/iOS.yml @@ -1,6 +1,7 @@ +--- name: iOS -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -14,9 +15,7 @@ on: - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -31,47 +30,54 @@ jobs: runs-on: macos-latest steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Cache CMake build folder - uses: actions/cache@v4 - with: - path: build - key: ${{ github.workflow }}-v3-${{ github.sha }} - restore-keys: ${{ github.workflow }}-v3- + - name: Cache CMake build folder + uses: actions/cache@v4 + with: + path: build + key: ${{ github.workflow }}-v3-${{ github.sha }} + restore-keys: ${{ github.workflow }}-v3- - - name: Configure CMake - # Use a bash shell so we can use the same syntax for environment variable - # access regardless of the host operating system - shell: bash - working-directory: ${{github.workspace}} - run: cmake -S. -Bbuild -DCMAKE_TOOLCHAIN_FILE=../CMake/platforms/ios.toolchain.cmake -DENABLE_BITCODE=0 -DPLATFORM=OS64 + - name: Configure CMake + # Use a bash shell so we can use the same syntax for environment variable + # access regardless of the host operating system + shell: bash + working-directory: ${{github.workspace}} + run: | + cmake \ + -S . \ + -B build \ + -D CMAKE_TOOLCHAIN_FILE=../CMake/platforms/ios.toolchain.cmake \ + -D ENABLE_BITCODE=0 \ + -D PLATFORM=OS64 - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: > - cmake --build build -j $(sysctl -n hw.physicalcpu) --config Release && - cd build && - mkdir Payload && - mv devilutionx.app Payload && - zip -r devilutionx-iOS.ipa Payload + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: > + cmake --build build -j $(sysctl -n hw.physicalcpu) --config Release && + cd build && + mkdir Payload && + mv devilutionx.app Payload && + zip -r devilutionx-iOS.ipa Payload - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-iOS.ipa - path: build/devilutionx-iOS.ipa + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-iOS.ipa + path: build/devilutionx-iOS.ipa - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: build/devilutionx-iOS.ipa - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: build/devilutionx-iOS.ipa + overwrite: true - - name: Clean up artifacts - run: rm -rf build/Payload build/*.ipa + - name: Clean up artifacts + run: rm -rf build/Payload build/*.ipa +... diff --git a/.github/workflows/macOS_x86_64.yml b/.github/workflows/macOS_x86_64.yml index f7730e568a7..693ad50cba0 100644 --- a/.github/workflows/macOS_x86_64.yml +++ b/.github/workflows/macOS_x86_64.yml @@ -1,6 +1,7 @@ +--- name: macOS x86_64 -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -14,9 +15,6 @@ on: - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -27,37 +25,43 @@ jobs: build: runs-on: macos-latest steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Create Build Environment - run: brew bundle install - - - name: Cache CMake build folder - uses: actions/cache@v4 - with: - path: build - key: ${{ github.workflow }}-v1-${{ github.sha }} - restore-keys: ${{ github.workflow }}-v1- - - - name: Build - working-directory: ${{github.workspace}} - shell: bash - env: - CMAKE_BUILD_TYPE: ${{github.event_name == 'release' && 'Release' || 'RelWithDebInfo'}} - run: | - cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=${{env.CMAKE_BUILD_TYPE}} -DBUILD_TESTING=OFF \ - -DMACOSX_STANDALONE_APP_BUNDLE=ON -DDISCORD_INTEGRATION=ON && \ - cmake --build build -j $(sysctl -n hw.physicalcpu) --target package && \ - mv build/devilutionx.dmg build/devilutionx-x86_64-macOS.dmg - - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-x86_64-macOS.dmg - path: build/devilutionx-x86_64-macOS.dmg - - - name: Clean up artifacts - run: rm -rf build/_CPack_Packages build/*.dmg + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Create Build Environment + run: brew bundle install + + - name: Cache CMake build folder + uses: actions/cache@v4 + with: + path: build + key: ${{ github.workflow }}-v1-${{ github.sha }} + restore-keys: ${{ github.workflow }}-v1- + + - name: Build + working-directory: ${{github.workspace}} + shell: bash + env: + CMAKE_BUILD_TYPE: ${{github.event_name == 'release' && 'Release' || 'RelWithDebInfo'}} + run: | + cmake \ + -S . \ + -B build \ + -D CMAKE_BUILD_TYPE=${{env.CMAKE_BUILD_TYPE}} \ + -D BUILD_TESTING=OFF \ + -D MACOSX_STANDALONE_APP_BUNDLE=ON \ + -D DISCORD_INTEGRATION=ON + cmake --build build -j $(sysctl -n hw.physicalcpu) --target package + mv build/devilutionx.dmg build/devilutionx-x86_64-macOS.dmg + + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-x86_64-macOS.dmg + path: build/devilutionx-x86_64-macOS.dmg + + - name: Clean up artifacts + run: rm -rf build/_CPack_Packages build/*.dmg +... diff --git a/.github/workflows/miyoo_mini_release.yml b/.github/workflows/miyoo_mini_release.yml index e97fd3e6178..3d2b932cd54 100644 --- a/.github/workflows/miyoo_mini_release.yml +++ b/.github/workflows/miyoo_mini_release.yml @@ -1,11 +1,9 @@ +--- name: Miyoo Mini Release Build -on: +on: # yamllint disable-line rule:truthy release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -14,39 +12,40 @@ concurrency: jobs: miyoo-mini: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - - name: Install toolchain - working-directory: ${{github.workspace}} - run: sudo Packaging/miyoo_mini/setup_toolchain.sh - - - name: Build - working-directory: ${{github.workspace}} - run: Packaging/miyoo_mini/build.sh - - - name: Upload-OnionOS-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-miyoo-mini-onion-os.zip - path: build-miyoo-mini/devilutionx-miyoo-mini-onion-os.zip - - - name: Upload-miniUI-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-miyoo-mini-miniui.zip - path: build-miyoo-mini/devilutionx-miyoo-mini-miniui.zip - - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: "build-miyoo-mini/devilutionx-*.zip" - file_glob: true - overwrite: true + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 + + - name: Install toolchain + working-directory: ${{github.workspace}} + run: sudo Packaging/miyoo_mini/setup_toolchain.sh + + - name: Build + working-directory: ${{github.workspace}} + run: Packaging/miyoo_mini/build.sh + + - name: Upload-OnionOS-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-miyoo-mini-onion-os.zip + path: build-miyoo-mini/devilutionx-miyoo-mini-onion-os.zip + + - name: Upload-miniUI-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-miyoo-mini-miniui.zip + path: build-miyoo-mini/devilutionx-miyoo-mini-miniui.zip + + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: "build-miyoo-mini/devilutionx-*.zip" + file_glob: true + overwrite: true +... diff --git a/.github/workflows/opendingux_release.yml b/.github/workflows/opendingux_release.yml index 04eee0d88a8..4753a4fb1da 100644 --- a/.github/workflows/opendingux_release.yml +++ b/.github/workflows/opendingux_release.yml @@ -1,11 +1,9 @@ +--- name: OpenDingux Release Build -on: +on: # yamllint disable-line rule:truthy release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -14,77 +12,90 @@ concurrency: jobs: gcw0: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y curl cmake git squashfs-tools && - curl -L https://github.com/OpenDingux/buildroot/releases/download/od-2022.09.22/opendingux-gcw0-toolchain.2022-09-22.tar.xz -o gcw0-toolchain.tar.xz && - sudo mkdir -p /opt/gcw0-toolchain && sudo chown -R "${USER}:" /opt/gcw0-toolchain && - tar -C /opt -xf gcw0-toolchain.tar.xz && - cd /opt/gcw0-toolchain && ./relocate-sdk.sh + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + curl \ + cmake \ + git \ + squashfs-tools + curl -L https://github.com/OpenDingux/buildroot/releases/download/od-2022.09.22/opendingux-gcw0-toolchain.2022-09-22.tar.xz -o gcw0-toolchain.tar.xz + sudo mkdir -p /opt/gcw0-toolchain + chown -R "${USER}:" /opt/gcw0-toolchain + tar -C /opt -xf gcw0-toolchain.tar.xz + cd /opt/gcw0-toolchain + ./relocate-sdk.sh - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: Packaging/OpenDingux/build.sh rg350 - env: - TOOLCHAIN: /opt/gcw0-toolchain + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: Packaging/OpenDingux/build.sh rg350 + env: + TOOLCHAIN: /opt/gcw0-toolchain - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-rg350.opk.zip - path: build-rg350/devilutionx-rg350.opk + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-rg350.opk.zip + path: build-rg350/devilutionx-rg350.opk - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: "build-rg350/devilutionx-rg350.opk" - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: "build-rg350/devilutionx-rg350.opk" + overwrite: true lepus: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt update && - sudo apt install -y curl cmake git squashfs-tools && - curl -L https://github.com/OpenDingux/buildroot/releases/download/od-2022.09.22/opendingux-lepus-toolchain.2022-09-22.tar.xz -o lepus-toolchain.tar.xz && - sudo mkdir -p /opt/lepus-toolchain && sudo chown -R "${USER}:" /opt/lepus-toolchain && - tar -C /opt -xf lepus-toolchain.tar.xz && - cd /opt/lepus-toolchain && ./relocate-sdk.sh + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + curl \ + cmake \ + git \ + squashfs-tools + curl -L https://github.com/OpenDingux/buildroot/releases/download/od-2022.09.22/opendingux-lepus-toolchain.2022-09-22.tar.xz -o lepus-toolchain.tar.xz + mkdir -p /opt/lepus-toolchain + chown -R "${USER}:" /opt/lepus-toolchain + tar -C /opt -xf lepus-toolchain.tar.xz + cd /opt/lepus-toolchain + ./relocate-sdk.sh - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: Packaging/OpenDingux/build.sh lepus - env: - TOOLCHAIN: /opt/lepus-toolchain + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: Packaging/OpenDingux/build.sh lepus + env: + TOOLCHAIN: /opt/lepus-toolchain - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-lepus.opk.zip - path: build-lepus/devilutionx-lepus.opk + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-lepus.opk.zip + path: build-lepus/devilutionx-lepus.opk - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: "build-lepus/devilutionx-lepus.opk" - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: "build-lepus/devilutionx-lepus.opk" + overwrite: true +... diff --git a/.github/workflows/retrofw_release.yml b/.github/workflows/retrofw_release.yml index a0d261e7e58..4efe02691d2 100644 --- a/.github/workflows/retrofw_release.yml +++ b/.github/workflows/retrofw_release.yml @@ -1,11 +1,9 @@ +--- name: RetroFW Release Build -on: +on: # yamllint disable-line rule:truthy release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -16,37 +14,45 @@ jobs: retrofw: runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y curl cmake git squashfs-tools gettext && - curl -L https://github.com/retrofw/retrofw.github.io/releases/download/v2.3/mipsel-RetroFW-linux-uclibc_sdk-buildroot.tar.gz -o retrofw-toolchain.tar.gz && - sudo mkdir -p /opt/retrofw-toolchain && sudo chown -R "${USER}:" /opt/retrofw-toolchain && - tar -C /opt/retrofw-toolchain --strip-components=1 -xf retrofw-toolchain.tar.gz && - cd /opt/retrofw-toolchain && ./relocate-sdk.sh + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + curl \ + cmake \ + git \ + squashfs-tools \ + gettext + curl -L https://github.com/retrofw/retrofw.github.io/releases/download/v2.3/mipsel-RetroFW-linux-uclibc_sdk-buildroot.tar.gz -o retrofw-toolchain.tar.gz + mkdir -p /opt/retrofw-toolchain + chown -R "${USER}:" /opt/retrofw-toolchain + tar -C /opt/retrofw-toolchain --strip-components=1 -xf retrofw-toolchain.tar.gz + cd /opt/retrofw-toolchain + ./relocate-sdk.sh - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: Packaging/OpenDingux/build.sh retrofw - env: - TOOLCHAIN: /opt/retrofw-toolchain + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: Packaging/OpenDingux/build.sh retrofw + env: + TOOLCHAIN: /opt/retrofw-toolchain - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-retrofw.opk.zip - path: build-retrofw/devilutionx-retrofw.opk + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-retrofw.opk.zip + path: build-retrofw/devilutionx-retrofw.opk - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: "build-retrofw/devilutionx-retrofw.opk" - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: "build-retrofw/devilutionx-retrofw.opk" + overwrite: true +... diff --git a/.github/workflows/s390x_qemu_big_endian_tests.yml b/.github/workflows/s390x_qemu_big_endian_tests.yml index 84cbdbee795..6a9616ba064 100644 --- a/.github/workflows/s390x_qemu_big_endian_tests.yml +++ b/.github/workflows/s390x_qemu_big_endian_tests.yml @@ -1,12 +1,10 @@ +--- name: s390x qemu tests (big-endian) # The test suite takes ~50m to run so we only trigger it manually -on: +on: # yamllint disable-line rule:truthy release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -15,32 +13,32 @@ concurrency: jobs: big-endian-qemu: - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Cache .ccache - uses: actions/cache@v4 - with: - path: .ccache - key: ${{ github.workflow }}-v1-${{ github.sha }} - restore-keys: ${{ github.workflow }}-v1- + - name: Cache .ccache + uses: actions/cache@v4 + with: + path: .ccache + key: ${{ github.workflow }}-v1-${{ github.sha }} + restore-keys: ${{ github.workflow }}-v1- - - name: Get the qemu container - run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes + - name: Get the qemu container + run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes - - name: Run tests - run: > - docker run --platform linux/s390x --rm --interactive --mount type=bind,source=$(pwd),target=/host s390x/alpine sh -c - " - apk add --update-cache g++ ninja cmake ccache sdl2-dev sdl2_image-dev fmt-dev libpng-dev jpeg-dev bzip2-dev gtest-dev wget && - cd /host && - export CCACHE_DIR=/host/.ccache && - cmake -S. -Bbuild -G Ninja -DNONET=ON -DNOSOUND=ON && - wget -nv -nc https://github.com/diasurgical/devilutionx-assets/releases/download/v2/spawn.mpq -P build && - cmake --build build -j $(nproc) && - ctest --test-dir build --output-on-failure -j $(nproc) - " + - name: Run tests + run: > + docker run --platform linux/s390x --rm --interactive --mount type=bind,source=$(pwd),target=/host s390x/alpine sh -c + " + apk add --update-cache g++ ninja cmake ccache sdl2-dev sdl2_image-dev fmt-dev libpng-dev jpeg-dev bzip2-dev gtest-dev wget && + cd /host && + export CCACHE_DIR=/host/.ccache && + cmake -S. -Bbuild -G Ninja -DNONET=ON -DNOSOUND=ON && + wget -nv -nc https://github.com/diasurgical/devilutionx-assets/releases/download/v2/spawn.mpq -P build && + cmake --build build -j $(nproc) && + ctest --test-dir build --output-on-failure -j $(nproc) + " diff --git a/.github/workflows/src_dist_release.yml b/.github/workflows/src_dist_release.yml index 5ecad2343ce..436efee4a25 100644 --- a/.github/workflows/src_dist_release.yml +++ b/.github/workflows/src_dist_release.yml @@ -1,11 +1,9 @@ +--- name: Build source tarball -on: +on: # yamllint disable-line rule:truthy release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' workflow_dispatch: concurrency: @@ -16,61 +14,92 @@ jobs: make_src_dist: runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y cmake curl libsdl2-dev libsdl2-image-dev libfmt-dev libsodium-dev libbz2-dev libgtest-dev libgmock-dev git smpq gettext python-is-python3 + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + cmake \ + curl \ + libsdl2-dev \ + libsdl2-image-dev \ + libfmt-dev \ + libsodium-dev \ + libbz2-dev \ + libgtest-dev \ + libgmock-dev \ + git \ + smpq \ + gettext \ + python-is-python3 - - name: Build - working-directory: ${{github.workspace}} - run: tools/make_src_dist.py && mv build-src-dist/devilutionx-*.tar.xz devilutionx-src.tar.xz + - name: Build + working-directory: ${{github.workspace}} + run: | + tools/make_src_dist.py + mv build-src-dist/devilutionx-*.tar.xz devilutionx-src.tar.xz - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-src.tar.xz - path: devilutionx-src.tar.xz + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-src.tar.xz + path: devilutionx-src.tar.xz - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: "devilutionx-src.tar.xz" - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: "devilutionx-src.tar.xz" + overwrite: true make_src_dist_fully_vendored: runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Create Build Environment - run: > - sudo apt-get update && - sudo apt-get install -y cmake curl libsdl2-dev libsdl2-image-dev libfmt-dev libsodium-dev libbz2-dev libgtest-dev libgmock-dev git smpq gettext python-is-python3 + - name: Create Build Environment + run: | + apt-get update + apt-get install -y \ + cmake \ + curl \ + libsdl2-dev \ + libsdl2-image-dev \ + libfmt-dev \ + libsodium-dev \ + libbz2-dev \ + libgtest-dev \ + libgmock-dev \ + git \ + smpq \ + gettext \ + python-is-python3 - - name: Build - working-directory: ${{github.workspace}} - run: tools/make_src_dist.py --fully_vendored && mv build-src-dist/devilutionx-*.tar.xz devilutionx-src-fully-vendored.tar.xz + - name: Build + working-directory: ${{github.workspace}} + run: | + tools/make_src_dist.py --fully_vendored + mv build-src-dist/devilutionx-*.tar.xz devilutionx-src-fully-vendored.tar.xz - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-src-fully-vendored.tar.xz - path: devilutionx-src-fully-vendored.tar.xz + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-src-fully-vendored.tar.xz + path: devilutionx-src-fully-vendored.tar.xz - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: "devilutionx-src-fully-vendored.tar.xz" - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: "devilutionx-src-fully-vendored.tar.xz" + overwrite: true +... diff --git a/.github/workflows/translations.yml b/.github/workflows/translations.yml index d5141aa6b83..0939061233b 100644 --- a/.github/workflows/translations.yml +++ b/.github/workflows/translations.yml @@ -1,6 +1,7 @@ +--- name: Validate translations -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -8,10 +9,11 @@ on: - '*.md' - 'docs/**' pull_request: - types: [ opened, synchronize ] + types: [opened, synchronize] paths-ignore: - '*.md' - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -21,15 +23,18 @@ jobs: fmt-check: runs-on: ubuntu-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Install polib - run: sudo apt-get update && sudo apt-get install -y python3-polib + - name: Install polib + run: | + apt-get update && \ + apt-get install -y python3-polib - - name: Check - working-directory: ${{github.workspace}} - shell: bash - run: python3 tools/validate_translations.py + - name: Check + working-directory: ${{github.workspace}} + shell: bash + run: python3 tools/validate_translations.py +... diff --git a/.github/workflows/xbox_nxdk.yml b/.github/workflows/xbox_nxdk.yml index abb286ba1b7..69e4324b41f 100644 --- a/.github/workflows/xbox_nxdk.yml +++ b/.github/workflows/xbox_nxdk.yml @@ -1,6 +1,7 @@ +--- name: Xbox -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -14,9 +15,7 @@ on: - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -25,52 +24,68 @@ concurrency: jobs: xbox: # `ubuntu-latest` is currently 20.04 but we require a newer clang. - runs-on: ubuntu-22.04 + runs-on: ubuntu-latest env: NXDK_DIR: /opt/nxdk steps: - - name: Install APT packages - run: sudo apt-get update && sudo apt-get install -y clang llvm lld bison flex cmake git gettext + - name: Install APT packages + run: | + apt-get update && \ + apt-get install -y \ + clang \ + llvm \ + lld \ + bison \ + flex \ + cmake \ + git \ + gettext - - name: Clone nxdk Repo - shell: bash - run: git clone --recursive --depth 1 https://github.com/XboxDev/nxdk.git "$NXDK_DIR" + - name: Clone nxdk Repo + shell: bash + run: git clone --recursive --depth 1 https://github.com/XboxDev/nxdk.git "$NXDK_DIR" - - name: Build nxdk - shell: bash - run: PATH="${NXDK_DIR}/bin:$PATH" make -j $(nproc) -C "$NXDK_DIR" NXDK_ONLY=1 CFLAGS=-O2 CXXFLAGS=-O2 all cxbe + - name: Build nxdk + shell: bash + run: PATH="${NXDK_DIR}/bin:$PATH" make -j $(nproc) -C "$NXDK_DIR" NXDK_ONLY=1 CFLAGS=-O2 CXXFLAGS=-O2 all cxbe - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: Configure CMake - working-directory: ${{github.workspace}} - env: - CMAKE_BUILD_TYPE: ${{github.event_name == 'release' && 'Release' || 'RelWithDebInfo'}} - run: cmake -S. -Bbuild-xbox -DCMAKE_BUILD_TYPE=${{env.CMAKE_BUILD_TYPE}} -DCMAKE_TOOLCHAIN_FILE=/opt/nxdk/share/toolchain-nxdk.cmake + - name: Configure CMake + working-directory: ${{github.workspace}} + env: + CMAKE_BUILD_TYPE: ${{github.event_name == 'release' && 'Release' || 'RelWithDebInfo'}} + run: | + cmake \ + -S . \ + -B build-xbox \ + -D CMAKE_BUILD_TYPE=${{env.CMAKE_BUILD_TYPE}} \ + -D CMAKE_TOOLCHAIN_FILE=/opt/nxdk/share/toolchain-nxdk.cmake - - name: Build - working-directory: ${{github.workspace}} - shell: bash - run: cmake --build build-xbox -j $(nproc) --target nxdk_xbe + - name: Build + working-directory: ${{github.workspace}} + shell: bash + run: cmake --build build-xbox -j $(nproc) --target nxdk_xbe - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-xbox - path: build-xbox/pkg/ + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-xbox + path: build-xbox/pkg/ - - name: Package Release - if: ${{ github.event_name == 'release' && !env.ACT }} - working-directory: ${{github.workspace}}/build-xbox/pkg - run: zip -r ../../devilutionx-xbox.zip . + - name: Package Release + if: ${{ github.event_name == 'release' && !env.ACT }} + working-directory: ${{github.workspace}}/build-xbox/pkg + run: zip -r ../../devilutionx-xbox.zip . - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: devilutionx-xbox.zip - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: devilutionx-xbox.zip + overwrite: true +... diff --git a/.github/workflows/xbox_one.yml b/.github/workflows/xbox_one.yml index 4624757def1..347dea06025 100644 --- a/.github/workflows/xbox_one.yml +++ b/.github/workflows/xbox_one.yml @@ -1,6 +1,7 @@ +--- name: Xbox One / Series -on: +on: # yamllint disable-line rule:truthy push: branches: - master @@ -14,9 +15,7 @@ on: - 'docs/**' release: types: [published] - paths-ignore: - - '*.md' - - 'docs/**' + workflow_dispatch: concurrency: group: ${{ github.workflow }}-${{ github.ref }} @@ -26,55 +25,56 @@ jobs: build: runs-on: windows-latest steps: - - name: Checkout - uses: actions/checkout@v4 - with: - fetch-depth: 0 + - name: Checkout + uses: actions/checkout@v4 + with: + fetch-depth: 0 - - name: ccache - uses: hendrikmuhs/ccache-action@v1.2 + - name: ccache + uses: hendrikmuhs/ccache-action@v1.2 - - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v1.3 - with: - msbuild-architecture: x64 + - name: Add msbuild to PATH + uses: microsoft/setup-msbuild@v1.3 + with: + msbuild-architecture: x64 - - name: Configure git - shell: cmd - run: | - git config --global core.filemode false - git config --global core.autocrlf false + - name: Configure git + shell: cmd + run: | + git config --global core.filemode false + git config --global core.autocrlf false - - name: Build - shell: cmd - run: | - cd ${{ github.workspace }}\Packaging\xbox-one - build.bat + - name: Build + shell: cmd + run: | + cd ${{ github.workspace }}\Packaging\xbox-one + build.bat - - name: Copy artifacts to package directory - run: > - New-Item -Path build\uwp-project -Name pkg -ItemType Directory -Force && - Get-Childitem -Path build\uwp-project\AppxPackages, build\uwp-project\Release - -Include Microsoft.VCLibs.x64.*.appx, devilutionX_*_x64.appx -File -Recurse | - Copy-Item -Destination build\uwp-project\pkg\ + - name: Copy artifacts to package directory + run: > + New-Item -Path build\uwp-project -Name pkg -ItemType Directory -Force && + Get-Childitem -Path build\uwp-project\AppxPackages, build\uwp-project\Release + -Include Microsoft.VCLibs.x64.*.appx, devilutionX_*_x64.appx -File -Recurse | + Copy-Item -Destination build\uwp-project\pkg\ - - name: Upload-Package - if: ${{ !env.ACT }} - uses: actions/upload-artifact@v4 - with: - name: devilutionx-xbox-one-series - if-no-files-found: error - path: | - build/uwp-project/pkg/ + - name: Upload-Package + if: ${{ !env.ACT }} + uses: actions/upload-artifact@v4 + with: + name: devilutionx-xbox-one-series + if-no-files-found: error + path: | + build/uwp-project/pkg/ - - name: Package Release - if: ${{ github.event_name == 'release' && !env.ACT }} - working-directory: ${{github.workspace}}/build/uwp-project/pkg/ - run: 7z a -r ../../../devilutionx-xbox-one-series.zip . + - name: Package Release + if: ${{ github.event_name == 'release' && !env.ACT }} + working-directory: ${{github.workspace}}/build/uwp-project/pkg/ + run: 7z a -r ../../../devilutionx-xbox-one-series.zip . - - name: Update Release - if: ${{ github.event_name == 'release' && !env.ACT }} - uses: svenstaro/upload-release-action@v2 - with: - file: devilutionx-xbox-one-series.zip - overwrite: true + - name: Update Release + if: ${{ github.event_name == 'release' && !env.ACT }} + uses: svenstaro/upload-release-action@v2 + with: + file: devilutionx-xbox-one-series.zip + overwrite: true +... diff --git a/.yamllint b/.yamllint new file mode 100644 index 00000000000..5782ae04d61 --- /dev/null +++ b/.yamllint @@ -0,0 +1,31 @@ +--- +yaml-files: + - '*.yaml' + - '*.yml' + - .yamllint +rules: + braces: enable + brackets: enable + colons: enable + commas: enable + comments: enable + comments-indentation: enable + document-end: enable + document-start: enable + empty-lines: enable + empty-values: disable + float-values: enable + hyphens: enable + indentation: enable + key-duplicates: enable + key-ordering: disable + line-length: + max: 120 + level: warning + new-line-at-end-of-file: enable + new-lines: enable + octal-values: enable + quoted-strings: disable + trailing-spaces: enable + truthy: enable +... diff --git a/codecov.yml b/codecov.yml index f42aba62321..c5bd6b63726 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,8 +1,9 @@ +--- codecov: - require_ci_to_pass: no + require_ci_to_pass: false notify: - wait_for_ci: no -comment: no + wait_for_ci: false +comment: false coverage: range: "45...85" status: @@ -10,10 +11,11 @@ coverage: default: target: 0% threshold: 0.02% - patch: no + patch: false ignore: - "3rdParty" - "test" flag_management: default_rules: carryforward: false +...