Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option change handlers should be registered outside of options.cpp #7638

Open
glebm opened this issue Jan 10, 2025 · 0 comments · May be fixed by #7639
Open

Option change handlers should be registered outside of options.cpp #7638

glebm opened this issue Jan 10, 2025 · 0 comments · May be fixed by #7639
Labels
build system

Comments

@glebm
Copy link
Collaborator

glebm commented Jan 10, 2025 •
edited
Loading

Almost everything depends on options.cpp and options.cpp depends on almost everything because the change handlers are registered withing options.cpp.

It'd be great to untangle this by moving the change handlers outside of options.cpp.

E.g. currently in options.cpp we have:

void OptionExperienceBarChanged()
{
	if (!gbRunGame)
		return;
	if (*sgOptions.Gameplay.experienceBar)
		InitXPBar();
	else
		FreeXPBar();
}
	experienceBar.SetValueChangedCallback(OptionExperienceBarChanged);

This code should be moved to xpbar.cpp to avoid this circular dependency.

This will let us do things like building data_file_test without depending on all of DevilutionX.
glebm added a commit to glebm/devilutionX that referenced this issue Jan 10, 2025
@glebm
sgOptions -> GetOptions()
430c488 
In C++, globals initialization order accross translation units is not
defined. Accessing a global via a function ensures that it is initialized.

This will be needed for diasurgical#7638, which will statically initialize change
handlers after the Options object has been initialized.
glebm added a commit to glebm/devilutionX that referenced this issue Jan 10, 2025
@glebm
sgOptions -> GetOptions()
b238bb6 
In C++, globals initialization order accross translation units is not
defined. Accessing a global via a function ensures that it is initialized.

This will be needed for diasurgical#7638, which will statically initialize change
handlers after the Options object has been initialized.
glebm added a commit to glebm/devilutionX that referenced this issue Jan 10, 2025
@glebm
sgOptions -> GetOptions()
0f42119 
In C++, globals initialization order accross translation units is not
defined. Accessing a global via a function ensures that it is initialized.

This will be needed for diasurgical#7638, which will statically initialize change
handlers after the Options object has been initialized.
@glebm glebm linked a pull request Jan 10, 2025 that will close this issue
Open
glebm added a commit to glebm/devilutionX that referenced this issue Jan 11, 2025
@glebm
Move option change handlers out of options.cpp
ba30fda 
Fixes diasurgical#7638
glebm added a commit to glebm/devilutionX that referenced this issue Jan 11, 2025
@glebm
Move option change handlers out of options.cpp
e3c6e8c 
Fixes diasurgical#7638
glebm added a commit to glebm/devilutionX that referenced this issue Jan 11, 2025
@glebm
sgOptions -> GetOptions()
fd70d99 
In C++, globals initialization order accross translation units is not
defined. Accessing a global via a function ensures that it is initialized.

This will be needed for diasurgical#7638, which will statically initialize change
handlers after the Options object has been initialized.
glebm added a commit to glebm/devilutionX that referenced this issue Jan 11, 2025
@glebm
Move option change handlers out of options.cpp
f702588 
Fixes diasurgical#7638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move option change handlers out of options.cpp glebm/devilutionX
1 participant
@glebm