Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize iterator #83

Open
2 tasks
bigerl opened this issue Mar 19, 2021 · 1 comment
Open
2 tasks

optimize iterator #83

bigerl opened this issue Mar 19, 2021 · 1 comment
Labels
enhancement New feature or request performance Affects the performance.

Comments

@bigerl
Copy link
Member

bigerl commented Mar 19, 2021

The iterator is not always as fast as it could be.

  • The current implementation resolves the dimensions in ascending order. We should try if it gets faster when we iterate the smallest dimension first (recursively).
  • Construction + move-assignment takes a while (observed in ResolveOperator)
@bigerl bigerl added enhancement New feature or request performance Affects the performance. labels Mar 19, 2021
@bigerl
Copy link
Member Author

bigerl commented Mar 24, 2021

@nkaralis I added the info from #84 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Affects the performance.
Projects
None yet
Development

No branches or pull requests

1 participant