-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New sample QR codes & JSON VCs #23
Comments
I'd like us to have a comprehensive set of credentials to test with and demonstrate the functionality we support in Learner Credential Wallet and VerifierPlus. |
@kayaelle feb 1 - UPDATE: I'm dynamically generating the VCs, and associated QR codes, from a file that provides the details for each type of test cred, and then saving the VCs and QRs to GitHub. @bmuramatsu quick question: Why avoid CBOR-LD? @dmitrizagidulin Do we have to use CBOR-LD? In other words, when the wallet scans a QR that contains an embedded VC (i.e, not a linked VC), will the wallet recognize anything other than the format that vp-qr uses, i.e, a VP encoded with CBOR-LD and formatted as describe in the vp-qr readme (https://github.com/digitalbazaar/vpqr): <format and version, 'VP1-'><multibase prefix, 'B'><base32 RFC4648 (no padding) encoded CBORLD> I guess what I'm asking is, does the wallet use the VP-QR library to decode the QR, and therefore only accepts that format? And so, all our sample QRs that embed VCs should follow that format? |
@dmitrizagidulin For the revoked credential samples, do we have a way to revoke credentials now, that the wallet/Verifier+ would recognize and check? I know we just talked on the TWG call about how the StatusList2020 is forthcoming, but in the interim, could I bodge something in, or is it just better to wait until the new signing package, with StatusList2020, is ready? |
@bmuramatsu @dmitrizagidulin I've generated all the different test credentials, which you can see here: https://github.com/jchartrand/dcc-test-creds Each 'type' of credential (expired, not expired, valid, not valid, etc.) has its own folder with three files in each: the json file, a QR containing a URL that points at the json file in GitHub, and a QR that contains the full json VC. I didn't add the full JSON QR for those that were bigger than 7K, which is the limit of the library I used. But, even the smallest of the json QRs is still really really dense, as you can see here: https://github.com/jchartrand/dcc-test-creds/blob/main/validBadge/validBadge.png And I can't, in fact, scan it from the LCW. I didn't use CBOR-LD but I also didn't do anything to the raw JSON. Is there some kind of compaction I should be doing? |
@jchartrand - no, no additional compaction is needed when using raw json. Testing that QR code above, I'm seeing it's giving a parsing error, so we need to debug why. |
@bmuramatsu - this ok to be closed? |
test-signer generates the codes as requested. Not written explicitly in the original issue was posting as generated credentials for testing to the Docs repo and editing or closing the previous sample credentials issue, #10 (And these need to be reviewed periodically and probably updated.) |
Requirements:
SVG:
Ancient Building Icon, listed as public domain
Features:
SVG:
Vector drawing of blue rosette ribbon, listed as public domain
The text was updated successfully, but these errors were encountered: