Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns in auction-marketplace #1

Open
damianlluch opened this issue Aug 15, 2021 · 1 comment
Open

Patterns in auction-marketplace #1

damianlluch opened this issue Aug 15, 2021 · 1 comment

Comments

@damianlluch
Copy link

Hi, I've been reading your work. I'm developing a similar marketplace with auction, and I have all the code in a single contract. I'm looking for a way to split it, but I don't know which is the right way.
I have seen that in your implementation you use the ERC721URIStorage contract... why did you use this approach?
And I would ask you, what do you think is the approach that I should use?
in principle I tried to implement inheritance of contracts, I understand how to separate them, but I don't know how to link them in migrations.

Best regards

@nikhil0360
Copy link
Collaborator

nikhil0360 commented Aug 16, 2021

  1. We have implemented ERC721URIStorage because it comes with a map (tokenID -> tokenURI) to store URL of NFT metadata (name, description, image) which we use in our frontend. Essentially you can use ERC721 contract and implement this map yourself if you need to store this URL on the blockchain.

  2. If your NFT token in auction and market place are unrelated you can separate them and deploy both the contracts separately. Now you have two contract address to work with - one for auction place and one for market place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants