Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting non-composer mode - at least a bit #19

Open
BluechipZellAmSee opened this issue Mar 15, 2024 · 1 comment
Open

Supporting non-composer mode - at least a bit #19

BluechipZellAmSee opened this issue Mar 15, 2024 · 1 comment

Comments

@BluechipZellAmSee
Copy link

I know you already stated to not support non-composer mode. Nevertheless I would like to ask you if you could make the following changes to your code:

Composer mode:
In DeeplTranslationService.php there is a check for composer mode on line 95. Maybe you could change this code to

if (Environment::isComposerMode() || class_exists(Translator::class)) {

Or maybe add a configuration option via ext_conf_template.txt like "I know what I'm doing, ignore composer mode restriction".

General
In ext_emconf.php change the PHP dependency constraint to 8.1.0-8.3.99 to align with composer.json

Background
The background to my request is that we still have projects in non-composer mode where we would like to use your extension. We can provide the necessary 3rd party libraries on our own but without the change in DeeplTranslationService.php we cannot use it without maintaining our own fork.

But of course I understand if you don't want to make those changes 😉

@dmitryd
Copy link
Owner

dmitryd commented Mar 25, 2024

None planned... Usually it is easy to rebuild projects to use composer and it adds a lot of benefits. Adding legacy code is not what I would like to add to any new extension. But I will keep the ticket open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants