Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newlines are not preserved in code blocks #1

Open
adamziel opened this issue Jun 10, 2024 · 5 comments
Open

Newlines are not preserved in code blocks #1

adamziel opened this issue Jun 10, 2024 · 5 comments

Comments

@adamziel
Copy link
Collaborator

I added a code block in the editor and pasted this:

 * Pair the site editor's nested iframe to the Service Worker.
 *
 * Without the patch below, the site editor initiates network requests that
 * aren't routed through the service worker. That's a known browser issue.

However, in the final markdown, I got this instead (in backtick fences):

 * Pair the site editor's nested iframe to the Service Worker. * * Without the patch below, the site editor initiates network requests that * aren't routed through the service worker. That's a known browser issue.
dmsnell added a commit that referenced this issue Jun 10, 2024
@dmsnell
Markdown: Convert Code Block newlines into <br> tags.
c762a5b 
Fixes #1.

When converting code blocks back into Markdown the newlines
were not being preserved. The original conversion changes `<br>`
tags into newlines, and this patch performs the reverse operation.
@dmsnell
Copy link
Owner

dmsnell commented Jun 10, 2024

Thanks for notifying. I think I ran into this at one point.

@dmsnell dmsnell mentioned this issue Jun 10, 2024
Closed
@dmsnell
Copy link
Owner

dmsnell commented Jun 10, 2024

@adamziel I'm unable to reproduce the missing newlines.

@dmsnell
Copy link
Owner

dmsnell commented Jul 3, 2024

@adamziel can you confirm that this is still an issue?

@adamziel
Copy link
Collaborator Author

adamziel commented Aug 9, 2024

@dmsnell do you have a Blueprint that installs the latest version of Blocky Formats so I could test it? We pivoted to offline mode so I don't have the setup fresh.

@ryanwelcher
Copy link
Contributor

This might be related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Markdown: Convert Code Block newlines into <br> tags. dmsnell/blocky-formats
3 participants
@adamziel @ryanwelcher @dmsnell