Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "python" out of "django-nose-test" #5

Open
srusskih opened this issue Nov 29, 2013 · 2 comments
Open

Move "python" out of "django-nose-test" #5

srusskih opened this issue Nov 29, 2013 · 2 comments

Comments

@srusskih
Copy link
Contributor

I want propose move python out of django-nose-test object and rename to python_interpreter

It will makes simple work flow for users how use SublimePythonIDE and SublimeJEDI (srusskih/SublimeJEDI#100)

How this will looks like:

{
    "folders":
    [
        {
            "path": "/home/sr/.virtualenvs/django1.6/example"
        }
    ],
    "settings": {
        "python_interpreter": "/home/sr/.virtualenvs/django1.6/bin/python",
        "django-nose-test": {
            "django-settings": "example.settings",
            "use-nose": false,
            "doted-notation": true
        }
    }
}

@dobarkod, what you think about that ?

@senko
Copy link
Member

senko commented Nov 29, 2013

Hey @srusskih thanks for the idea. I wouldn't like to pollute the global settings object in ST with our or settings, except if this setting becomes a kind of standard across other Python-related packages for ST (which I see you're working on with other projects).

That is, I wouldn't want to require the user to put something outside of "django-nose-test" for configuring DjangoNoseTest.

As the middle ground, we could first check if "python" is defined in "django-nose-test", then try to fall-back to "python_interpreter" in settings. This would allow people who use "python_interpreter" for different extensions to have it in one place, while still allowing them to modify only DjangoNoseTest behaviour if they so choose.

@srusskih
Copy link
Contributor Author

Going agree with you, checking python path in "django-nose-test" settings first is a better then just move it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants