Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the c# image #14

Closed
bmesuere opened this issue Aug 4, 2019 · 0 comments
Closed

clean up the c# image #14

bmesuere opened this issue Aug 4, 2019 · 0 comments
Assignees

Comments

@bmesuere
Copy link
Member

bmesuere commented Aug 4, 2019

The C# image doesn't adhere to docker file best practices and doesn't pass our linting. While this might look innocent, it can have unexpected consequences: images built at a different time on a different worker node can behave differently.

To fix this, the following changes need to be made:

dodona-csharp.dockerfile:1 DL3006 Always tag the version of an image explicitly
dodona-csharp.dockerfile:4 DL3009 Delete the apt-get lists after installing something
dodona-csharp.dockerfile:5 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
dodona-csharp.dockerfile:5 DL3015 Avoid additional packages by specifying `--no-install-recommends`
dodona-csharp.dockerfile:6 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
dodona-csharp.dockerfile:6 DL3015 Avoid additional packages by specifying `--no-install-recommends`
dodona-csharp.dockerfile:19 DL3002 Last USER should not be root

Inspiration on fixing these can be found at #13 and at https://github.com/hadolint/hadolint/wiki.

bmesuere added a commit that referenced this issue Aug 13, 2019
Fix lint errors in c-sharp dockerfile #14
@chvp chvp closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants