Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up the prolog image #16

Closed
bmesuere opened this issue Aug 4, 2019 · 0 comments · Fixed by #25
Closed

clean up the prolog image #16

bmesuere opened this issue Aug 4, 2019 · 0 comments · Fixed by #25
Assignees

Comments

@bmesuere
Copy link
Member

bmesuere commented Aug 4, 2019

The prolog image doesn't adhere to docker file best practices and doesn't pass our linting. While this might look innocent, it can have unexpected consequences: images built at a different time on a different worker node can behave differently.

To fix this, the following changes need to be made:

dodona-prolog.dockerfile:4 DL3009 Delete the apt-get lists after installing something
dodona-prolog.dockerfile:5 DL3008 Pin versions in apt get install. Instead of `apt-get install <package>` use `apt-get install <package>=<version>`
dodona-prolog.dockerfile:5 DL3015 Avoid additional packages by specifying `--no-install-recommends`
dodona-prolog.dockerfile:24 DL3002 Last USER should not be root

Inspiration on fixing these can be found at #13 and at https://github.com/hadolint/hadolint/wiki.

beardhatcode added a commit that referenced this issue Aug 13, 2019
Reduces the size of this image from 196MB to 175MB

Manualy tested on Dodona 2.11.4 localy

https://github.com/dodona-edu/dodona/releases/tag/2.11.4

Fixes #16
beardhatcode added a commit that referenced this issue Aug 13, 2019
Reduces the size of this image from 196MB to 175MB

Manualy tested on Dodona 2.11.4 localy

https://github.com/dodona-edu/dodona/releases/tag/2.11.4

Fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants