You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I’ve been exploring the Dojo documentation, and on the models overview page, I noticed that the last example is a bit confusing. It uses a position variable that isn’t declared in the example.
First, this function won’t compile.
Second, it’s hard to understand the logic behind the example (even if that’s not its main purpose).
If you’re okay with it, I’d be happy to propose a small enhancement to clarify this point.
Additionally, I’ve already submitted a PR (#373) to address the mandatory traits defined on models.
Let me know what you think!
Best regards,
Nicode
The text was updated successfully, but these errors were encountered:
Hi,
I’ve been exploring the Dojo documentation, and on the models overview page, I noticed that the last example is a bit confusing. It uses a position variable that isn’t declared in the example.
First, this function won’t compile.
Second, it’s hard to understand the logic behind the example (even if that’s not its main purpose).
If you’re okay with it, I’d be happy to propose a small enhancement to clarify this point.
Additionally, I’ve already submitted a PR (#373) to address the mandatory traits defined on models.
Let me know what you think!
Best regards,
Nicode
The text was updated successfully, but these errors were encountered: