Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on the Models Overview Page #374

Open
ncoquelet opened this issue Jan 9, 2025 · 0 comments
Open

Feedback on the Models Overview Page #374

ncoquelet opened this issue Jan 9, 2025 · 0 comments

Comments

@ncoquelet
Copy link

Hi,

I’ve been exploring the Dojo documentation, and on the models overview page, I noticed that the last example is a bit confusing. It uses a position variable that isn’t declared in the example.

First, this function won’t compile.
Second, it’s hard to understand the logic behind the example (even if that’s not its main purpose).
If you’re okay with it, I’d be happy to propose a small enhancement to clarify this point.

Additionally, I’ve already submitted a PR (#373) to address the mandatory traits defined on models.

Let me know what you think!

Best regards,
Nicode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant