Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Typescript bindings contracts order is random #2943

Open
rsodre opened this issue Jan 22, 2025 · 1 comment
Open

[BUG] Typescript bindings contracts order is random #2943

rsodre opened this issue Jan 22, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@rsodre
Copy link

rsodre commented Jan 22, 2025

Describe the bug

Every time we generate typescript bindings, the order of methods in contracts.gen.ts is changed.
It makes it impossible to review the generated contracts.
And is terrible to track changes and update the client after contract changes.

To Reproduce

Build dojo-starter multiple times and compare the bindings.
If there was no change in the models, they should not be updated.

Expected behavior

The generated sources should be deterministic and historically accurate.

Additional context

follow-up of #2782

@rsodre rsodre added the bug Something isn't working label Jan 22, 2025
@glihm
Copy link
Collaborator

glihm commented Jan 23, 2025

Hum, this effectively should have been resolved with #2782. cc @MartianGreed to see if it's something than can be done at the plugin level, or if some modifications are required on the common layer for the bindgen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants