Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excessive Uptight.Result massaging into JSON #31

Open
2 tasks
cognivore opened this issue Jun 11, 2023 · 0 comments
Open
2 tasks

Excessive Uptight.Result massaging into JSON #31

cognivore opened this issue Jun 11, 2023 · 0 comments

Comments

@cognivore
Copy link
Contributor

Why?

We already have a ToJSON instance for AssertionError, including Trace. We must include traces in our patches.

image

How?

  • Replace the true error cases with just using Jason.encode
  • Bonus points: think about a way to unify "email already sent" clause and "new user clause", I don't think that we should handle this logic in the error handling, but I can hear an argument for this being the exact point where to do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cognivore