fix: dynamic library builds for Reanimated #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominicstop - I think this'll clean up the build errors with Reanimated, although we can probably still close #118 since you merged 5aeff10 |
|
hello, thank you for fixing the build issues w/ reanimated the github action for testing the diff. builds just stopped working recently, so i have to go back to local builds. i will go through the PR's bit by bit and revert the changes i've made; thank you for your patience. |
coolsoftwaretyler
deleted the
fix/reanimated-dynamic-library-in-example-app
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will fix the build error reported in this comment, based on the fix in software-mansion/react-native-reanimated#6062
To reproduce:
yarn nuke:allyarn installcd example/iospod cache clean --all && USE_FRAMEWORKS="dynamic" pod install