Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade example-expo to SDK 52 #122

Conversation

coolsoftwaretyler
Copy link
Contributor

This PR upgrades the Expo example to SDK 52 by following this walkthrough, and then the upgrade helper since we aren't using continuous native generation. I also updated the react-native-ios-utilities dependency to 5.0.0-53

I also turned on the new architecture by default in the Expo example.

To test this out:

  1. Clean your build folders with yarn nuke:all (or some less intense process if you don't want to nuke your whole machine).
  2. Run yarn install
  3. cd example-expo/ios && pod install (you may need to run with --repo-update, but hopefully the Podfile.lock changes make that unnecessary)
  4. Run cd .. && yarn ios to run the iOS Expo build.
  5. Run yarn android to run the Android Expo build

The app should build and run as expected (although the Android app of course doesn't do anything, other than build and show text).

@coolsoftwaretyler
Copy link
Contributor Author

Hey @dominicstop - here's an update to the Expo example that gets it up to SDK 52 and enables the new architecture. I think everything is working!

@dominicstop
Copy link
Owner

hello, thank you for submitting a PR to for upgrade the Expo example to SDK 52 (in spite of the holiday season, and your well-earned vacation)

i had some troubles upgrading the expo example project in the past, so i couldn't test compatibility; i will use your instructions/changes for more testing (hopefully to catch build errors before submitting a release)

hopefully, i'll be able to add an expo example for the other libraries soon-ish

@dominicstop dominicstop merged commit 92dc87b into dominicstop:master Dec 19, 2024
@coolsoftwaretyler coolsoftwaretyler deleted the twilliams/chore-upgrade-expo-example-to-sdk-52 branch December 19, 2024 16:53
@coolsoftwaretyler
Copy link
Contributor Author

Thanks!

I will make a note to see if I can scaffold an Expo example app using continuous native generation, which would make Expo upgrades much simpler in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants