-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lacks CSS theming / fill & stroke colors not changeable in CSS #84
Comments
hi @rossbulat Are you talking about styling the player, or styling your animations using css classes? |
Hey @samuelOsborne, thanks for following up! I'm talking about styling animations using css classes. |
@rossbulat Great. This is due to using the shadow DOM, I was looking in to ways of disabling its uses via a prop. This will fix the issue, will try and get a fix out for this week and ping you |
@samuelOsborne Fantastic, thank you! Looking forward to testing, this will definitely cut down on the complexity of hosting multiple variations of SVG 👍 |
Hey @samuelOsborne, did I miss the publish? |
Hey @rossbulat no, haven't gotten round to finishing it unfortunately |
Ah ok, I will keep an eye out for updates! |
hey @rossbulat we're going with a better solution that will be released towards the end of this month, so I wont be implementing removing the shadowDOM for the moment |
Thanks for the update @samuelOsborne, looking forward to seeing the solution! |
The dot lottie player seemingly ignores all external CSS rules, even if
important!
, with the inlinefill
andstroke
attributes always taking precedence.This is troublesome for theming (we don't really want to maintain 2 versions of the icons for light, dark modes).
Perhaps I am missing something but I am not seeing a way to inject classes or change the default colors of dot lottie animations.
It would be useful for the
<dotlottie-player>
tag to take asvgStyle
attribute that would allow us to access the CSS directly within the shadow root.The text was updated successfully, but these errors were encountered: